RefCounted types should not have public destructors, chrome/browser/ part 5

chrome/browser/prefs/overlay_user_pref_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/overlay_user_pref_store.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 
 OverlayUserPrefStore::OverlayUserPrefStore(
     PersistentPrefStore* underlay)
     : underlay_(underlay) {
   underlay_->AddObserver(this);
 }
 
-OverlayUserPrefStore::~OverlayUserPrefStore() {
-  underlay_->RemoveObserver(this);
-}
-
 bool OverlayUserPrefStore::IsSetInOverlay(const std::string& key) const {
   return overlay_.GetValue(key, NULL);
 }
 
 void OverlayUserPrefStore::AddObserver(PrefStore::Observer* observer) {
   observers_.AddObserver(observer);
 }
 
 void OverlayUserPrefStore::RemoveObserver(PrefStore::Observer* observer) {
   observers_.RemoveObserver(observer);
@@ skipping 99 matching lines @@
 
 void OverlayUserPrefStore::CommitPendingWrite() {
   underlay_->CommitPendingWrite();
   // We do not write our content intentionally.
 }
 
 void OverlayUserPrefStore::ReportValueChanged(const std::string& key) {
   FOR_EACH_OBSERVER(PrefStore::Observer, observers_, OnPrefValueChanged(key));
 }
 
+void OverlayUserPrefStore::OnPrefValueChanged(const std::string& key) {
+  if (!overlay_.GetValue(GetOverlayKey(key), NULL))
+    ReportValueChanged(GetOverlayKey(key));
+}
+
+void OverlayUserPrefStore::OnInitializationCompleted(bool succeeded) {
+  FOR_EACH_OBSERVER(PrefStore::Observer, observers_,
+                    OnInitializationCompleted(succeeded));
+}
+
 void OverlayUserPrefStore::RegisterOverlayPref(const std::string& key) {
   RegisterOverlayPref(key, key);
 }
 
 void OverlayUserPrefStore::RegisterOverlayPref(
     const std::string& overlay_key,
     const std::string& underlay_key) {
   DCHECK(!overlay_key.empty()) << "Overlay key is empty";
   DCHECK(overlay_to_underlay_names_map_.find(overlay_key) ==
          overlay_to_underlay_names_map_.end()) <<
       "Overlay key already registered";
   DCHECK(!underlay_key.empty()) << "Underlay key is empty";
   DCHECK(underlay_to_overlay_names_map_.find(underlay_key) ==
          underlay_to_overlay_names_map_.end()) <<
       "Underlay key already registered";
   overlay_to_underlay_names_map_[overlay_key] = underlay_key;
   underlay_to_overlay_names_map_[underlay_key] = overlay_key;
 }
 
-void OverlayUserPrefStore::OnPrefValueChanged(const std::string& key) {
-  if (!overlay_.GetValue(GetOverlayKey(key), NULL))
-    ReportValueChanged(GetOverlayKey(key));
-}
-
-void OverlayUserPrefStore::OnInitializationCompleted(bool succeeded) {
-  FOR_EACH_OBSERVER(PrefStore::Observer, observers_,
-                    OnInitializationCompleted(succeeded));
+OverlayUserPrefStore::~OverlayUserPrefStore() {
+  underlay_->RemoveObserver(this);
 }
 
 const std::string& OverlayUserPrefStore::GetOverlayKey(
     const std::string& underlay_key) const {
   NamesMap::const_iterator i =
       underlay_to_overlay_names_map_.find(underlay_key);
   return i != underlay_to_overlay_names_map_.end() ? i->second : underlay_key;
 }
 
 const std::string& OverlayUserPrefStore::GetUnderlayKey(
     const std::string& overlay_key) const {
   NamesMap::const_iterator i =
       overlay_to_underlay_names_map_.find(overlay_key);
   return i != overlay_to_underlay_names_map_.end() ? i->second : overlay_key;
 }
 
 bool OverlayUserPrefStore::ShallBeStoredInOverlay(
     const std::string& key) const {
   return overlay_to_underlay_names_map_.find(key) !=
       overlay_to_underlay_names_map_.end();
 }