RefCounted types should not have public destructors, chrome/browser/ part 5

chrome/browser/prefs/command_line_pref_store_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <gtest/gtest.h>
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/prefs/command_line_pref_store.h"
 #include "chrome/browser/prefs/proxy_config_dictionary.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "ui/base/ui_base_switches.h"
 
 namespace {
 
+const char unknown_bool[] = "unknown_switch";
+const char unknown_string[] = "unknown_other_switch";
+
+}  // namespace
+
 class TestCommandLinePrefStore : public CommandLinePrefStore {
  public:
   explicit TestCommandLinePrefStore(CommandLine* cl)
       : CommandLinePrefStore(cl) {}
 
   bool ProxySwitchesAreValid() {
     return ValidateProxySwitches();
   }
 
   void VerifyProxyMode(ProxyPrefs::ProxyMode expected_mode) {
@@ skipping 15 matching lines @@
     const ListValue* list_value = static_cast<const ListValue*>(value);
     ASSERT_EQ(cipher_count, list_value->GetSize());
 
     std::string cipher_string;
     for (ListValue::const_iterator it = list_value->begin();
          it != list_value->end(); ++it, ++ciphers) {
       ASSERT_TRUE((*it)->GetAsString(&cipher_string));
       EXPECT_EQ(*ciphers, cipher_string);
     }
   }
+
+ private:
+  virtual ~TestCommandLinePrefStore() {}
 };
 
-const char unknown_bool[] = "unknown_switch";
-const char unknown_string[] = "unknown_other_switch";
-
-}  // namespace
-
 // Tests a simple string pref on the command line.
 TEST(CommandLinePrefStoreTest, SimpleStringPref) {
   CommandLine cl(CommandLine::NO_PROGRAM);
   cl.AppendSwitchASCII(switches::kLang, "hi-MOM");
   scoped_refptr<CommandLinePrefStore> store = new CommandLinePrefStore(&cl);
 
   const Value* actual = NULL;
   EXPECT_EQ(PrefStore::READ_OK,
             store->GetValue(prefs::kApplicationLocale, &actual));
   std::string result;
@@ skipping 136 matching lines @@
   cl3.AppendSwitchASCII(switches::kCipherSuiteBlacklist,
                         "0x0004;MOAR;0x0005");
   scoped_refptr<TestCommandLinePrefStore> store3 =
       new TestCommandLinePrefStore(&cl3);
   const char* const expected_ciphers3[] = {
     "0x0004;MOAR;0x0005"
   };
   store3->VerifySSLCipherSuites(expected_ciphers3,
                                 arraysize(expected_ciphers3));
 }