Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: chrome/browser/password_manager/password_store_win.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store_win.h" 5 #include "chrome/browser/password_manager/password_store_win.h"
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 21 matching lines...) Expand all
32 // We hold a copy of the |form| used in GetLoginsImpl as a pointer. If the 32 // We hold a copy of the |form| used in GetLoginsImpl as a pointer. If the
33 // form is not set (is NULL), then we are not a GetLogins request. 33 // form is not set (is NULL), then we are not a GetLogins request.
34 void SetLoginsRequestForm(const PasswordForm& form) { 34 void SetLoginsRequestForm(const PasswordForm& form) {
35 form_.reset(new PasswordForm(form)); 35 form_.reset(new PasswordForm(form));
36 } 36 }
37 PasswordForm* form() const { 37 PasswordForm* form() const {
38 return form_.get(); 38 return form_.get();
39 } 39 }
40 bool IsLoginsRequest() const { return !!form_.get(); } 40 bool IsLoginsRequest() const { return !!form_.get(); }
41 41
42 protected:
43 virtual ~FormGetLoginsRequest() {}
44
42 private: 45 private:
43 scoped_ptr<PasswordForm> form_; 46 scoped_ptr<PasswordForm> form_;
44 }; 47 };
45 48
46 } // namespace 49 } // namespace
47 50
48 // Handles requests to WebDataService. 51 // Handles requests to WebDataService.
49 class PasswordStoreWin::DBHandler : public WebDataServiceConsumer { 52 class PasswordStoreWin::DBHandler : public WebDataServiceConsumer {
50 public: 53 public:
51 DBHandler(WebDataService* web_data_service, 54 DBHandler(WebDataService* web_data_service,
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 PasswordStore::ForwardLoginsResult(request); 206 PasswordStore::ForwardLoginsResult(request);
204 } 207 }
205 } 208 }
206 209
207 void PasswordStoreWin::GetLoginsImpl(GetLoginsRequest* request, 210 void PasswordStoreWin::GetLoginsImpl(GetLoginsRequest* request,
208 const PasswordForm& form) { 211 const PasswordForm& form) {
209 static_cast<FormGetLoginsRequest*>(request)->SetLoginsRequestForm(form); 212 static_cast<FormGetLoginsRequest*>(request)->SetLoginsRequestForm(form);
210 213
211 PasswordStoreDefault::GetLoginsImpl(request, form); 214 PasswordStoreDefault::GetLoginsImpl(request, form);
212 } 215 }
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_store.h ('k') | chrome/browser/policy/configuration_policy_pref_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698