Disable CHECK(false) in NetworkChangeNotifier::Create on ChromeOS

Disable CHECK(false) in NetworkChangeNotifier::Create on ChromeOS

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132169

[oshima, 2012-04-13 07:31:18]

I totally forgot about ash_shell.
https://chromiumcodereview.appspot.com/10012006 broke ash_shell because
ash_shell can't use chromeos'es notifier (yet) and still goes through this path.
This CL temporarily disable CHECK for chromeos.

[willchan no longer on Chromium, 2012-04-13 07:38:13]

LGTM

On Fri, Apr 13, 2012 at 9:31 AM, <oshima@chromium.org> wrote:

> Reviewers: willchan,
>
> Message:
> I totally forgot about ash_shell.
>
https://chromiumcodereview.**appspot.com/10012006<https://chromiumcodereview....
ash_shell because
> ash_shell can't use chromeos'es notifier (yet) and still goes through this
> path.
> This CL temporarily disable CHECK for chromeos.
>
> Description:
> Disable CHECK(false) in NetworkChangeNotifier::Create on ChromeOS
>
> BUG=none
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/10068035/<http://codereview.chromium.org/100...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M net/base/network_change_**notifier.cc
>
>
> Index: net/base/network_change_**notifier.cc
> diff --git a/net/base/network_change_**notifier.cc
> b/net/base/network_change_**notifier.cc
> index 5e5e18824c6aef101d08c8c0923ed9**70f7f5cf6d..**
> ec9cae06d79da8f6beac0145b10ff2**635e5206e8 100644
> --- a/net/base/network_change_**notifier.cc
> +++ b/net/base/network_change_**notifier.cc
> @@ -57,7 +57,12 @@ NetworkChangeNotifier* NetworkChangeNotifier::Create(**)
> {
>   return network_change_notifier;
>  #elif defined(OS_CHROMEOS) || defined(OS_ANDROID)
>   // ChromeOS and Android builds MUST use their own class factory.
> +#if !defined(OS_CHROMEOS)
> +  // TODO(oshima): ash_shell do not have access to chromeos'es
> +  // notifier yet. Re-enable this when chromeos'es notifier moved to
> +  // chromeos root directory. crbug.com/119298.
>   CHECK(false);
> +#endif
>   return NULL;
>  #elif defined(OS_LINUX)
>   return NetworkChangeNotifierLinux::**Create();
>
>
>

[commit-bot: I haz the power, 2012-04-13 08:44:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10068035/2001

[commit-bot: I haz the power, 2012-04-13 10:12:03]

Change committed as 132169