views: Initialize message_box_title_ in the initalizer list.

chrome/browser/ui/views/simple_message_box_views.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_SIMPLE_MESSAGE_BOX_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_SIMPLE_MESSAGE_BOX_VIEWS_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
@@ skipping 11 matching lines @@
                               public base::RefCounted<SimpleMessageBoxViews> {
  public:
   static void ShowErrorBox(gfx::NativeWindow parent_window,
                            const string16& title,
                            const string16& message);
   static bool ShowYesNoBox(gfx::NativeWindow parent_window,
                            const string16& title,
                            const string16& message);
 
   // Returns true if the Accept button was clicked.
-  bool accepted() const { return disposition_ == DISPOSITION_OK; }
+  bool accepted() const { return disposition_type_ == DISPOSITION_OK; }
 
  private:
   friend class base::RefCounted<SimpleMessageBoxViews>;
 
   // The state of the dialog when closing.
   enum DispositionType {
     DISPOSITION_UNKNOWN,
     DISPOSITION_CANCEL,
     DISPOSITION_OK
   };
@@ skipping 11 matching lines @@
 
   // Overridden from views::WidgetDelegate:
   virtual string16 GetWindowTitle() const OVERRIDE;
   virtual void DeleteDelegate() OVERRIDE;
   virtual ui::ModalType GetModalType() const OVERRIDE;
   virtual views::View* GetContentsView() OVERRIDE;
   virtual views::Widget* GetWidget() OVERRIDE;
   virtual const views::Widget* GetWidget() const OVERRIDE;
 
   SimpleMessageBoxViews(gfx::NativeWindow parent_window,
-                        DialogType type,
+                        DialogType dialog_type,
                         const string16& title,
                         const string16& message);
   virtual ~SimpleMessageBoxViews();
 
   // MessageLoop::Dispatcher implementation.
   // Dispatcher method. This returns true if the menu was canceled, or
   // if the message is such that the menu should be closed.
   virtual bool Dispatch(const base::NativeEvent& event) OVERRIDE;
 
-  const DialogType type_;
-  string16 message_box_title_;
+  const DialogType dialog_type_;
+  DispositionType disposition_type_;

[Peter Kasting, 2012/04/13 09:12:32]

Nit: While it's not wrong, I don't think the |disposition_type_| name is clearer
or more distinct -- if anything I think it's a tiny bit less good. 
(|dialog_type_| is fine.)

+  const string16 window_title_;
   views::MessageBoxView* message_box_view_;
-  DispositionType disposition_;
 
   DISALLOW_COPY_AND_ASSIGN(SimpleMessageBoxViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_SIMPLE_MESSAGE_BOX_VIEWS_H_