Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: net/base/network_delegate.h

Issue 10068021: Fix file access on Chrome for ChromeOS on Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review changes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/shell_network_delegate.cc ('k') | net/base/network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_delegate.h
diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h
index 34909ea04320c2593315bd4e910778c5cafd4245..77c3ff2bf52aa89c27bdc6877d9f4217fdb13215 100644
--- a/net/base/network_delegate.h
+++ b/net/base/network_delegate.h
@@ -14,6 +14,7 @@
#include "net/base/auth.h"
#include "net/base/completion_callback.h"
+class FilePath;
class GURL;
namespace net {
@@ -77,14 +78,16 @@ class NetworkDelegate : public base::NonThreadSafe {
const AuthChallengeInfo& auth_info,
const AuthCallback& callback,
AuthCredentials* credentials);
- bool NotifyReadingCookies(const URLRequest* request,
+ bool NotifyReadingCookies(const URLRequest& request,
const CookieList& cookie_list);
- bool NotifySettingCookie(const URLRequest* request,
+ bool NotifySettingCookie(const URLRequest& request,
const std::string& cookie_line,
CookieOptions* options);
+ bool NotifyFileAccessRequested(const URLRequest& request,
willchan no longer on Chromium 2012/04/20 00:14:03 Anything that's got a bool return value probably s
Greg Spencer (Chromium) 2012/04/20 19:21:28 Done. I renamed the cookie related ones too. (Ren
+ const FilePath& path) const;
private:
- // This is the interface for subclasses of NetworkDelegate to implement. This
+ // This is the interface for subclasses of NetworkDelegate to implement. These
// member functions will be called by the respective public notification
// member function, which will perform basic sanity checking.
@@ -182,16 +185,23 @@ class NetworkDelegate : public base::NonThreadSafe {
// Called when reading cookies to allow the network delegate to block access
// to the cookie. This method will never be invoked when
// LOAD_DO_NOT_SEND_COOKIES is specified.
- virtual bool CanGetCookies(const URLRequest* request,
+ virtual bool CanGetCookies(const URLRequest& request,
const CookieList& cookie_list) = 0;
// Called when a cookie is set to allow the network delegate to block access
// to the cookie. This method will never be invoked when
// LOAD_DO_NOT_SAVE_COOKIES is specified.
- virtual bool CanSetCookie(const URLRequest* request,
+ virtual bool CanSetCookie(const URLRequest& request,
const std::string& cookie_line,
CookieOptions* options) = 0;
+
+ // Called when a file access is attempted to allow the network delegate to
+ // allow or block access to the given file path. Returns true if access is
+ // allowed.
+ virtual bool CanAccessFile(const URLRequest& request,
+ const FilePath& path) const = 0;
+
};
} // namespace net
« no previous file with comments | « content/shell/shell_network_delegate.cc ('k') | net/base/network_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698