Fix file access on Chrome for ChromeOS on Linux

chrome/browser/net/chrome_network_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/chrome_network_delegate.h"
 
+#include "base/chromeos/chromeos_version.h"

[achuithb, 2012/04/19 20:05:56]

Shouldn't this be under #if defined(OS_CHROMEOS)?

[Greg Spencer (Chromium), 2012/04/19 20:51:17]

Whoops.  Yep. Done.

 #include "base/logging.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/extensions/api/proxy/proxy_api.h"
 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
 #include "chrome/browser/extensions/extension_event_router_forwarder.h"
 #include "chrome/browser/extensions/extension_info_map.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
@@ skipping 280 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         base::Bind(&TabSpecificContentSettings::CookieChanged,
                    render_process_id, render_view_id,
                    request->url(), request->first_party_for_cookies(),
                    cookie_line, *options, !allow));
   }
 
   return allow;
 }
+
+bool ChromeNetworkDelegate::CanAccessFile(const net::URLRequest* request,
+                                          const FilePath& path) {
+#if defined(OS_CHROMEOS)
+  static const char* const kLocalAccessWhiteList[] = {

[achuithb, 2012/04/19 20:05:56]

Could you please add a comment here stating that we disallow access to all files
except ones under these white-listed directories on chromeos devices?

[Greg Spencer (Chromium), 2012/04/19 20:51:17]

Done.

+      "/home/chronos/user/Downloads",
+      "/home/chronos/user/log",
+      "/media",
+      "/opt/oem",
+      "/usr/share/chromeos-assets",
+      "/tmp",
+      "/var/log",
+  };
+
+  // If we're running Chrome for ChromeOS on Linux, we want to allow files
+  // within the user's Downloads directory.
+  if (!base::chromeos::IsRunningOnChromeOS()) {
+    const char* home = getenv("HOME");

[achuithb, 2012/04/19 20:05:56]

I think you should just return true here. We only care about the white list on
the device.

[Greg Spencer (Chromium), 2012/04/19 20:51:17]

Done.  I do worry a bit that making it act differently than the "real thing"
might delay finding a bug in new code until it runs on the device.  But then
none of the other directories in the whitelist are even mapped properly when
running on Linux anyhow, so I guess it doesn't matter.

+    if (home && strlen(home) > 0) {
+      FilePath home_path(home);
+      home_path = home_path.AppendASCII("Downloads");
+      if (home_path.IsParent(path))
+        return true;
+    }
+  }
+
+  for (size_t i = 0; i < arraysize(kLocalAccessWhiteList); ++i) {
+    const FilePath white_listed_path(kLocalAccessWhiteList[i]);
+    // FilePath::operator== should probably handle trailing separators.
+    if (white_listed_path == path.StripTrailingSeparators() ||
+        white_listed_path.IsParent(path)) {
+      return true;
+    }
+  }
+  return false;
+#else  // !defined(OS_CHROMEOS)
+  // On other platforms we allow file:// access by default.
+  return true;
+#endif
+}