Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: gpu/command_buffer/service/query_manager.cc

Issue 10067035: RefCounted types should not have public destructors, media/ and gpu/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/query_manager.cc
diff --git a/gpu/command_buffer/service/query_manager.cc b/gpu/command_buffer/service/query_manager.cc
index c8f06a3e35ebb6551d5e8041e2373ffe9da04ede..e9a68552290d376551f28b725802a4c13b1d3ac9 100644
--- a/gpu/command_buffer/service/query_manager.cc
+++ b/gpu/command_buffer/service/query_manager.cc
@@ -17,13 +17,14 @@ class AllSamplesPassedQuery : public QueryManager::Query {
AllSamplesPassedQuery(
QueryManager* manager, GLenum target, int32 shm_id, uint32 shm_offset,
GLuint service_id);
- virtual ~AllSamplesPassedQuery();
virtual bool Begin() OVERRIDE;
virtual bool End(uint32 submit_count) OVERRIDE;
virtual bool Process() OVERRIDE;
virtual void Destroy(bool have_context) OVERRIDE;
private:
+ virtual ~AllSamplesPassedQuery();
+
// Service side query id.
GLuint service_id_;
};
@@ -73,7 +74,6 @@ class CommandsIssuedQuery : public QueryManager::Query {
public:
CommandsIssuedQuery(
QueryManager* manager, GLenum target, int32 shm_id, uint32 shm_offset);
- virtual ~CommandsIssuedQuery();
virtual bool Begin() OVERRIDE;
virtual bool End(uint32 submit_count) OVERRIDE;
@@ -81,6 +81,8 @@ class CommandsIssuedQuery : public QueryManager::Query {
virtual void Destroy(bool have_context) OVERRIDE;
private:
+ virtual ~CommandsIssuedQuery();
+
base::TimeTicks begin_time_;
};

Powered by Google App Engine
This is Rietveld 408576698