Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: media/filters/file_data_source.h

Issue 10067035: RefCounted types should not have public destructors, media/ and gpu/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_FILTERS_FILE_DATA_SOURCE_H_ 5 #ifndef MEDIA_FILTERS_FILE_DATA_SOURCE_H_
6 #define MEDIA_FILTERS_FILE_DATA_SOURCE_H_ 6 #define MEDIA_FILTERS_FILE_DATA_SOURCE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
11 #include "base/synchronization/lock.h" 11 #include "base/synchronization/lock.h"
12 #include "media/base/data_source.h" 12 #include "media/base/data_source.h"
13 13
14 namespace media { 14 namespace media {
15 15
16 // Basic data source that treats the URL as a file path, and uses the file 16 // Basic data source that treats the URL as a file path, and uses the file
17 // system to read data for a media pipeline. 17 // system to read data for a media pipeline.
18 class MEDIA_EXPORT FileDataSource : public DataSource { 18 class MEDIA_EXPORT FileDataSource : public DataSource {
19 public: 19 public:
20 FileDataSource(); 20 FileDataSource();
21 FileDataSource(bool disable_file_size); 21 FileDataSource(bool disable_file_size);
22 virtual ~FileDataSource();
23 22
24 PipelineStatus Initialize(const std::string& url); 23 PipelineStatus Initialize(const std::string& url);
25 24
26 // Implementation of DataSource. 25 // Implementation of DataSource.
27 virtual void set_host(DataSourceHost* host) OVERRIDE; 26 virtual void set_host(DataSourceHost* host) OVERRIDE;
28 virtual void Stop(const base::Closure& callback) OVERRIDE; 27 virtual void Stop(const base::Closure& callback) OVERRIDE;
29 virtual void Read(int64 position, int size, uint8* data, 28 virtual void Read(int64 position, int size, uint8* data,
30 const DataSource::ReadCB& read_cb) OVERRIDE; 29 const DataSource::ReadCB& read_cb) OVERRIDE;
31 virtual bool GetSize(int64* size_out) OVERRIDE; 30 virtual bool GetSize(int64* size_out) OVERRIDE;
32 virtual bool IsStreaming() OVERRIDE; 31 virtual bool IsStreaming() OVERRIDE;
33 virtual void SetBitrate(int bitrate) OVERRIDE; 32 virtual void SetBitrate(int bitrate) OVERRIDE;
34 33
35 private: 34 private:
36 // Only allow factories and tests to create this object. 35 // Only allow factories and tests to create this object.
37 // 36 //
38 // TODO(scherkus): I'm getting tired of these factories getting in the way 37 // TODO(scherkus): I'm getting tired of these factories getting in the way
39 // of my tests!!! 38 // of my tests!!!
40 FRIEND_TEST_ALL_PREFIXES(FileDataSourceTest, OpenFile); 39 FRIEND_TEST_ALL_PREFIXES(FileDataSourceTest, OpenFile);
41 FRIEND_TEST_ALL_PREFIXES(FileDataSourceTest, ReadData); 40 FRIEND_TEST_ALL_PREFIXES(FileDataSourceTest, ReadData);
42 FRIEND_TEST_ALL_PREFIXES(FileDataSourceTest, Seek); 41 FRIEND_TEST_ALL_PREFIXES(FileDataSourceTest, Seek);
43 42
43 virtual ~FileDataSource();
44
44 // Informs the host of changes in total and buffered bytes. 45 // Informs the host of changes in total and buffered bytes.
45 void UpdateHostBytes(); 46 void UpdateHostBytes();
46 47
47 // File handle. NULL if not initialized or an error occurs. 48 // File handle. NULL if not initialized or an error occurs.
48 FILE* file_; 49 FILE* file_;
49 50
50 // Size of the file in bytes. 51 // Size of the file in bytes.
51 int64 file_size_; 52 int64 file_size_;
52 53
53 // True if the FileDataSource should ignore its set file size, false 54 // True if the FileDataSource should ignore its set file size, false
54 // otherwise. 55 // otherwise.
55 bool disable_file_size_; 56 bool disable_file_size_;
56 57
57 // Critical section that protects all of the DataSource methods to prevent 58 // Critical section that protects all of the DataSource methods to prevent
58 // a Stop from happening while in the middle of a file I/O operation. 59 // a Stop from happening while in the middle of a file I/O operation.
59 // TODO(ralphl): Ideally this would use asynchronous I/O or we will know 60 // TODO(ralphl): Ideally this would use asynchronous I/O or we will know
60 // that we will block for a short period of time in reads. Otherwise, we can 61 // that we will block for a short period of time in reads. Otherwise, we can
61 // hang the pipeline Stop. 62 // hang the pipeline Stop.
62 base::Lock lock_; 63 base::Lock lock_;
63 64
64 DISALLOW_COPY_AND_ASSIGN(FileDataSource); 65 DISALLOW_COPY_AND_ASSIGN(FileDataSource);
65 }; 66 };
66 67
67 } // namespace media 68 } // namespace media
68 69
69 #endif // MEDIA_FILTERS_FILE_DATA_SOURCE_H_ 70 #endif // MEDIA_FILTERS_FILE_DATA_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698