ui/gfx/gl/gl_surface.h - Issue 10067034: RefCounted types should not have public destructors, printing/ and ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/gl/gl_surface.h

Issue 10067034: RefCounted types should not have public destructors, printing/ and ui/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/gl/gl_surface.h

diff --git a/ui/gfx/gl/gl_surface.h b/ui/gfx/gl/gl_surface.h

index 0c61ea8921afc4ba8fc29f02fb0c39ebc1045c96..d6523a2c3371745a5a5b7b426ba1fe6727b30d58 100644

--- a/ui/gfx/gl/gl_surface.h

+++ b/ui/gfx/gl/gl_surface.h

@@ -122,7 +122,6 @@ class GL_EXPORT GLSurface : public base::RefCounted<GLSurface> {

class GL_EXPORT GLSurfaceAdapter : public GLSurface {

public:

explicit GLSurfaceAdapter(GLSurface* surface);

- virtual ~GLSurfaceAdapter();

virtual bool Initialize() OVERRIDE;

virtual void Destroy() OVERRIDE;

@@ -143,6 +142,9 @@ class GL_EXPORT GLSurfaceAdapter : public GLSurface {

GLSurface* surface() const { return surface_.get(); }

+ protected:

+ virtual ~GLSurfaceAdapter();

private:

scoped_refptr<GLSurface> surface_;

DISALLOW_COPY_AND_ASSIGN(GLSurfaceAdapter);