Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/login/login_prompt_mac.mm ('k') | chrome/browser/ui/webui/bookmarks_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/about_ui.cc
diff --git a/chrome/browser/ui/webui/about_ui.cc b/chrome/browser/ui/webui/about_ui.cc
index eb82960a3bced8080b722fd87d5e59c4e2dc3179..458b43c9c80bdb7883fd62bef3dec0884ca692a3 100644
--- a/chrome/browser/ui/webui/about_ui.cc
+++ b/chrome/browser/ui/webui/about_ui.cc
@@ -744,12 +744,16 @@ class AboutDnsHandler : public base::RefCountedThreadSafe<AboutDnsHandler> {
}
private:
+ friend class base::RefCountedThreadSafe<AboutDnsHandler>;
+
AboutDnsHandler(AboutUIHTMLSource* source, int request_id)
: source_(source),
request_id_(request_id) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
}
+ virtual ~AboutDnsHandler() {}
+
// Calls FinishOnUIThread() on completion.
void StartOnUIThread() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
« no previous file with comments | « chrome/browser/ui/login/login_prompt_mac.mm ('k') | chrome/browser/ui/webui/bookmarks_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698