Issue 10067031: Memory leak fix in FileSystemURLRequestJobTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10067031: Memory leak fix in FileSystemURLRequestJobTest (Closed)

Created:
8 years, 8 months ago by kinuko

Modified:
8 years, 8 months ago

Reviewers:
adamk, tzik

CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Memory leak fix in FileSystemURLRequestJobTest I've introduced a memory leak in the previous change (r10065011). Now we close a file asynchronously after job->Kill() is called, we need to wait until the task runs before a test exits. BUG=none TEST=no memtest error in FileSystemURLRequestJobTest.*

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	webkit/fileapi/file_system_url_request_job_unittest.cc	View		4 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

8 years, 8 months ago (2012-04-13 10:08:09 UTC) #3

On 2012/04/13 09:23:55, tzik wrote:
> lgtm

Merging into http://codereview.chromium.org/10080001/ and closing this...

Expand Messages | Collapse Messages