Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10067023: Add support for default values of IPC_STRUCT_MEMBER. (Closed)

Created:
8 years, 8 months ago by jbates
Modified:
8 years, 8 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for default values of IPC_STRUCT_MEMBER. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132435

Patch Set 1 #

Total comments: 2

Patch Set 2 : tsepez feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/tools/ipclist/ipcfuzz.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_macros.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M ipc/ipc_message_null_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/param_traits_log_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/param_traits_read_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/param_traits_write_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/struct_constructor_macros.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jbates
8 years, 8 months ago (2012-04-13 18:00:35 UTC) #1
jam
I'll defer to Tom who wrote these macros.
8 years, 8 months ago (2012-04-13 18:02:33 UTC) #2
Tom Sepez
LGTM. https://chromiumcodereview.appspot.com/10067023/diff/1/ipc/ipc_message_macros.h File ipc/ipc_message_macros.h (right): https://chromiumcodereview.appspot.com/10067023/diff/1/ipc/ipc_message_macros.h#newcode205 ipc/ipc_message_macros.h:205: #define IPC_STRUCT_MEMBER(type, name, ...) type name; Nit: maybe ...
8 years, 8 months ago (2012-04-13 18:22:37 UTC) #3
jbates
https://chromiumcodereview.appspot.com/10067023/diff/1/ipc/ipc_message_macros.h File ipc/ipc_message_macros.h (right): https://chromiumcodereview.appspot.com/10067023/diff/1/ipc/ipc_message_macros.h#newcode205 ipc/ipc_message_macros.h:205: #define IPC_STRUCT_MEMBER(type, name, ...) type name; On 2012/04/13 18:22:37, ...
8 years, 8 months ago (2012-04-14 00:35:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/10067023/4002
8 years, 8 months ago (2012-04-14 00:36:41 UTC) #5
commit-bot: I haz the power
Try job failure for 10067023-4002 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-14 00:58:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/10067023/4002
8 years, 8 months ago (2012-04-14 01:01:59 UTC) #7
commit-bot: I haz the power
Try job failure for 10067023-4002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-14 02:47:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/10067023/4002
8 years, 8 months ago (2012-04-16 16:52:05 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 19:13:04 UTC) #10
Change committed as 132435

Powered by Google App Engine
This is Rietveld 408576698