Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: net/proxy/proxy_resolver_js_bindings.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_config_service_mac.cc ('k') | net/proxy/proxy_script_decider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_js_bindings.cc
diff --git a/net/proxy/proxy_resolver_js_bindings.cc b/net/proxy/proxy_resolver_js_bindings.cc
index 08b84acd417fc78aa8eb8376a8cc73814e78aa46..48dab35b2380702c4e59dc15e119fe2a29c7c7e3 100644
--- a/net/proxy/proxy_resolver_js_bindings.cc
+++ b/net/proxy/proxy_resolver_js_bindings.cc
@@ -43,6 +43,9 @@ class ErrorNetlogParams : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~ErrorNetlogParams() {}
+
private:
const int line_number_;
const string16 message_;
@@ -53,8 +56,7 @@ class ErrorNetlogParams : public NetLog::EventParameters {
// Event parameters for a PAC alert().
class AlertNetlogParams : public NetLog::EventParameters {
public:
- explicit AlertNetlogParams(const string16& message) : message_(message) {
- }
+ explicit AlertNetlogParams(const string16& message) : message_(message) {}
virtual Value* ToValue() const OVERRIDE {
DictionaryValue* dict = new DictionaryValue();
@@ -62,6 +64,9 @@ class AlertNetlogParams : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~AlertNetlogParams() {}
+
private:
const string16 message_;
« no previous file with comments | « net/proxy/proxy_config_service_mac.cc ('k') | net/proxy/proxy_script_decider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698