Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: net/cookies/cookie_monster_unittest.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_monster_store_test.cc ('k') | net/disk_cache/net_log_parameters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster_unittest.cc
diff --git a/net/cookies/cookie_monster_unittest.cc b/net/cookies/cookie_monster_unittest.cc
index a6b59d01f69eda94f0dc60c668d6f80eec28c46c..d2706a511ac3c1ff994a3b1fff6961c44eb8c25c 100644
--- a/net/cookies/cookie_monster_unittest.cc
+++ b/net/cookies/cookie_monster_unittest.cc
@@ -45,6 +45,9 @@ class NewMockPersistentCookieStore
MOCK_METHOD1(DeleteCookie, void(const CookieMonster::CanonicalCookie& cc));
MOCK_METHOD1(SetClearLocalStateOnExit, void(bool clear_local_state));
MOCK_METHOD1(Flush, void(const base::Closure& callback));
+
+ private:
+ virtual ~NewMockPersistentCookieStore() {}
};
const char* kTopLevelDomainPlus1 = "http://www.harvard.edu";
@@ -2232,6 +2235,8 @@ class FlushablePersistentStore : public CookieMonster::PersistentCookieStore {
}
private:
+ virtual ~FlushablePersistentStore() {}
+
volatile int flush_count_;
};
@@ -2250,6 +2255,8 @@ class CallbackCounter : public base::RefCountedThreadSafe<CallbackCounter> {
private:
friend class base::RefCountedThreadSafe<CallbackCounter>;
+ ~CallbackCounter() {}
+
volatile int callback_count_;
};
« no previous file with comments | « net/cookies/cookie_monster_store_test.cc ('k') | net/disk_cache/net_log_parameters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698