Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: net/cookies/cookie_monster_store_test.h

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_monster.cc ('k') | net/cookies/cookie_monster_store_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster_store_test.h
diff --git a/net/cookies/cookie_monster_store_test.h b/net/cookies/cookie_monster_store_test.h
index a05ddd3b5538a4b14bddc5cb9437869223327e2a..fd4218d4caeb8ca4aa4af07418dda321ebacd57c 100644
--- a/net/cookies/cookie_monster_store_test.h
+++ b/net/cookies/cookie_monster_store_test.h
@@ -33,13 +33,15 @@ class LoadedCallbackTask
LoadedCallbackTask(LoadedCallback loaded_callback,
std::vector<CookieMonster::CanonicalCookie*> cookies);
- ~LoadedCallbackTask();
void Run() {
loaded_callback_.Run(cookies_);
}
private:
+ friend class base::RefCountedThreadSafe<LoadedCallbackTask>;
+ ~LoadedCallbackTask();
+
LoadedCallback loaded_callback_;
std::vector<CookieMonster::CanonicalCookie*> cookies_;
@@ -72,7 +74,6 @@ class MockPersistentCookieStore
typedef std::vector<CookieStoreCommand> CommandList;
MockPersistentCookieStore();
- virtual ~MockPersistentCookieStore();
void SetLoadExpectation(
bool return_value,
@@ -100,6 +101,9 @@ class MockPersistentCookieStore
// No files are created so nothing to clear either
virtual void SetClearLocalStateOnExit(bool clear_local_state) OVERRIDE;
+ protected:
+ virtual ~MockPersistentCookieStore();
+
private:
CommandList commands_;
@@ -157,7 +161,6 @@ class MockSimplePersistentCookieStore
: public CookieMonster::PersistentCookieStore {
public:
MockSimplePersistentCookieStore();
- virtual ~MockSimplePersistentCookieStore();
virtual void Load(const LoadedCallback& loaded_callback) OVERRIDE;
@@ -177,6 +180,9 @@ class MockSimplePersistentCookieStore
virtual void SetClearLocalStateOnExit(bool clear_local_state) OVERRIDE;
+ protected:
+ virtual ~MockSimplePersistentCookieStore();
+
private:
typedef std::map<int64, CookieMonster::CanonicalCookie>
CanonicalCookieMap;
« no previous file with comments | « net/cookies/cookie_monster.cc ('k') | net/cookies/cookie_monster_store_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698