Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: net/base/host_resolver_impl.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/file_stream_net_log_parameters.cc ('k') | net/base/host_resolver_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/host_resolver_impl.cc
diff --git a/net/base/host_resolver_impl.cc b/net/base/host_resolver_impl.cc
index 0525459591a9d09606b2974c2e962d1d837988e3..541246f8b4d3785d4f644bc3c0830120b668f660 100644
--- a/net/base/host_resolver_impl.cc
+++ b/net/base/host_resolver_impl.cc
@@ -175,6 +175,9 @@ class CallSystemHostResolverProc : public HostResolverProc {
addr_list,
os_error);
}
+
+ protected:
+ virtual ~CallSystemHostResolverProc() {}
};
// Extra parameters to attach to the NetLog when the resolve failed.
@@ -216,6 +219,9 @@ class ProcTaskFailedParams : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~ProcTaskFailedParams() {}
+
private:
const uint32 attempt_number_;
const int net_error_;
@@ -237,6 +243,9 @@ class DnsTaskFailedParams : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~DnsTaskFailedParams() {}
+
private:
const int net_error_;
const int dns_error_;
@@ -265,6 +274,9 @@ class RequestInfoParameters : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~RequestInfoParameters() {}
+
private:
const HostResolver::RequestInfo info_;
const NetLog::Source source_;
@@ -284,6 +296,9 @@ class JobCreationParameters : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~JobCreationParameters() {}
+
private:
const std::string host_;
const NetLog::Source source_;
@@ -303,6 +318,9 @@ class JobAttachParameters : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~JobAttachParameters() {}
+
private:
const NetLog::Source source_;
const RequestPriority priority_;
@@ -326,6 +344,9 @@ class DnsConfigParameters : public NetLog::EventParameters {
return value;
}
+ protected:
+ virtual ~DnsConfigParameters() {}
+
private:
DnsConfig config_; // Does not include DnsHosts to save memory and work.
const size_t num_hosts_;
@@ -635,6 +656,9 @@ class HostResolverImpl::ProcTask
}
private:
+ friend class base::RefCountedThreadSafe<ProcTask>;
+ ~ProcTask() {}
+
void StartLookupAttempt() {
DCHECK(origin_loop_->BelongsToCurrentThread());
base::TimeTicks start_time = base::TimeTicks::Now();
« no previous file with comments | « net/base/file_stream_net_log_parameters.cc ('k') | net/base/host_resolver_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698