Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: net/base/default_server_bound_cert_store_unittest.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/default_server_bound_cert_store.cc ('k') | net/base/file_stream_net_log_parameters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/default_server_bound_cert_store_unittest.cc
diff --git a/net/base/default_server_bound_cert_store_unittest.cc b/net/base/default_server_bound_cert_store_unittest.cc
index fb94234a0f08e09dc80347ae28c15b9030bd2c07..38053c9603a601f0a519655cfae29821b96d72b4 100644
--- a/net/base/default_server_bound_cert_store_unittest.cc
+++ b/net/base/default_server_bound_cert_store_unittest.cc
@@ -20,7 +20,6 @@ class MockPersistentStore
: public DefaultServerBoundCertStore::PersistentStore {
public:
MockPersistentStore();
- virtual ~MockPersistentStore();
// DefaultServerBoundCertStore::PersistentStore implementation.
virtual bool Load(
@@ -33,6 +32,9 @@ class MockPersistentStore
virtual void SetClearLocalStateOnExit(bool clear_local_state) OVERRIDE;
virtual void Flush(const base::Closure& completion_task) OVERRIDE;
+ protected:
+ virtual ~MockPersistentStore();
+
private:
typedef std::map<std::string, DefaultServerBoundCertStore::ServerBoundCert>
ServerBoundCertMap;
@@ -42,8 +44,6 @@ class MockPersistentStore
MockPersistentStore::MockPersistentStore() {}
-MockPersistentStore::~MockPersistentStore() {}
-
bool MockPersistentStore::Load(
std::vector<DefaultServerBoundCertStore::ServerBoundCert*>* certs) {
ServerBoundCertMap::iterator it;
@@ -72,6 +72,8 @@ void MockPersistentStore::Flush(const base::Closure& completion_task) {
NOTREACHED();
}
+MockPersistentStore::~MockPersistentStore() {}
+
TEST(DefaultServerBoundCertStoreTest, TestLoading) {
scoped_refptr<MockPersistentStore> persistent_store(new MockPersistentStore);
« no previous file with comments | « net/base/default_server_bound_cert_store.cc ('k') | net/base/file_stream_net_log_parameters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698