Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: net/spdy/spdy_stream.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/udp/udp_data_transfer_param.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_stream.h" 5 #include "net/spdy/spdy_stream.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/stringprintf.h" 10 #include "base/stringprintf.h"
(...skipping 24 matching lines...) Expand all
35 } 35 }
36 36
37 namespace { 37 namespace {
38 38
39 class NetLogSpdyStreamWindowUpdateParameter : public NetLog::EventParameters { 39 class NetLogSpdyStreamWindowUpdateParameter : public NetLog::EventParameters {
40 public: 40 public:
41 NetLogSpdyStreamWindowUpdateParameter(SpdyStreamId stream_id, 41 NetLogSpdyStreamWindowUpdateParameter(SpdyStreamId stream_id,
42 int32 delta, 42 int32 delta,
43 int32 window_size) 43 int32 window_size)
44 : stream_id_(stream_id), delta_(delta), window_size_(window_size) {} 44 : stream_id_(stream_id), delta_(delta), window_size_(window_size) {}
45
45 virtual Value* ToValue() const { 46 virtual Value* ToValue() const {
46 DictionaryValue* dict = new DictionaryValue(); 47 DictionaryValue* dict = new DictionaryValue();
47 dict->SetInteger("id", static_cast<int>(stream_id_)); 48 dict->SetInteger("id", static_cast<int>(stream_id_));
48 dict->SetInteger("delta", delta_); 49 dict->SetInteger("delta", delta_);
49 dict->SetInteger("window_size", window_size_); 50 dict->SetInteger("window_size", window_size_);
50 return dict; 51 return dict;
51 } 52 }
53
52 private: 54 private:
55 virtual ~NetLogSpdyStreamWindowUpdateParameter() {}
56
53 const SpdyStreamId stream_id_; 57 const SpdyStreamId stream_id_;
54 const int32 delta_; 58 const int32 delta_;
55 const int32 window_size_; 59 const int32 window_size_;
56 DISALLOW_COPY_AND_ASSIGN(NetLogSpdyStreamWindowUpdateParameter); 60 DISALLOW_COPY_AND_ASSIGN(NetLogSpdyStreamWindowUpdateParameter);
57 }; 61 };
58 62
59 bool ContainsUpperAscii(const std::string& str) { 63 bool ContainsUpperAscii(const std::string& str) {
60 for (std::string::const_iterator i(str.begin()); i != str.end(); ++i) { 64 for (std::string::const_iterator i(str.begin()); i != str.end(); ++i) {
61 if (*i >= 'A' && *i <= 'Z') { 65 if (*i >= 'A' && *i <= 'Z') {
62 return true; 66 return true;
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 UMA_HISTOGRAM_TIMES("Net.SpdyStreamDownloadTime", 768 UMA_HISTOGRAM_TIMES("Net.SpdyStreamDownloadTime",
765 recv_last_byte_time_ - recv_first_byte_time_); 769 recv_last_byte_time_ - recv_first_byte_time_);
766 UMA_HISTOGRAM_TIMES("Net.SpdyStreamTime", 770 UMA_HISTOGRAM_TIMES("Net.SpdyStreamTime",
767 recv_last_byte_time_ - send_time_); 771 recv_last_byte_time_ - send_time_);
768 772
769 UMA_HISTOGRAM_COUNTS("Net.SpdySendBytes", send_bytes_); 773 UMA_HISTOGRAM_COUNTS("Net.SpdySendBytes", send_bytes_);
770 UMA_HISTOGRAM_COUNTS("Net.SpdyRecvBytes", recv_bytes_); 774 UMA_HISTOGRAM_COUNTS("Net.SpdyRecvBytes", recv_bytes_);
771 } 775 }
772 776
773 } // namespace net 777 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/udp/udp_data_transfer_param.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698