Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: net/http/http_pipelined_connection_impl.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/dns/dns_transaction.cc ('k') | net/http/http_pipelined_connection_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_pipelined_connection_impl.h" 5 #include "net/http/http_pipelined_connection_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 20 matching lines...) Expand all
31 const std::string& feedback) 31 const std::string& feedback)
32 : source_(source), feedback_(feedback) {} 32 : source_(source), feedback_(feedback) {}
33 33
34 virtual Value* ToValue() const OVERRIDE { 34 virtual Value* ToValue() const OVERRIDE {
35 DictionaryValue* dict = new DictionaryValue; 35 DictionaryValue* dict = new DictionaryValue;
36 dict->Set("source_dependency", source_.ToValue()); 36 dict->Set("source_dependency", source_.ToValue());
37 dict->SetString("feedback", feedback_); 37 dict->SetString("feedback", feedback_);
38 return dict; 38 return dict;
39 } 39 }
40 40
41 protected:
42 virtual ~ReceivedHeadersParameters() {}
43
41 private: 44 private:
42 const NetLog::Source source_; 45 const NetLog::Source source_;
43 const std::string feedback_; 46 const std::string feedback_;
44 }; 47 };
45 48
46 class StreamClosedParameters : public NetLog::EventParameters { 49 class StreamClosedParameters : public NetLog::EventParameters {
47 public: 50 public:
48 StreamClosedParameters(const NetLog::Source& source, bool not_reusable) 51 StreamClosedParameters(const NetLog::Source& source, bool not_reusable)
49 : source_(source), not_reusable_(not_reusable) {} 52 : source_(source), not_reusable_(not_reusable) {}
50 53
51 virtual Value* ToValue() const OVERRIDE { 54 virtual Value* ToValue() const OVERRIDE {
52 DictionaryValue* dict = new DictionaryValue; 55 DictionaryValue* dict = new DictionaryValue;
53 dict->Set("source_dependency", source_.ToValue()); 56 dict->Set("source_dependency", source_.ToValue());
54 dict->SetBoolean("not_reusable", not_reusable_); 57 dict->SetBoolean("not_reusable", not_reusable_);
55 return dict; 58 return dict;
56 } 59 }
57 60
61 protected:
62 virtual ~StreamClosedParameters() {}
63
58 private: 64 private:
59 const NetLog::Source source_; 65 const NetLog::Source source_;
60 const bool not_reusable_; 66 const bool not_reusable_;
61 }; 67 };
62 68
63 } // anonymous namespace 69 } // anonymous namespace
64 70
65 HttpPipelinedConnectionImpl::HttpPipelinedConnectionImpl( 71 HttpPipelinedConnectionImpl::HttpPipelinedConnectionImpl(
66 ClientSocketHandle* connection, 72 ClientSocketHandle* connection,
67 HttpPipelinedConnection::Delegate* delegate, 73 HttpPipelinedConnection::Delegate* delegate,
(...skipping 758 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 } 832 }
827 833
828 HttpPipelinedConnectionImpl::StreamInfo::StreamInfo() 834 HttpPipelinedConnectionImpl::StreamInfo::StreamInfo()
829 : state(STREAM_CREATED) { 835 : state(STREAM_CREATED) {
830 } 836 }
831 837
832 HttpPipelinedConnectionImpl::StreamInfo::~StreamInfo() { 838 HttpPipelinedConnectionImpl::StreamInfo::~StreamInfo() {
833 } 839 }
834 840
835 } // namespace net 841 } // namespace net
OLDNEW
« no previous file with comments | « net/dns/dns_transaction.cc ('k') | net/http/http_pipelined_connection_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698