Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: net/base/file_stream_net_log_parameters.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Deprecated cookiestore fix Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/file_stream_net_log_parameters.h ('k') | net/base/host_resolver_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/file_stream_net_log_parameters.h" 5 #include "net/base/file_stream_net_log_parameters.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 8
9 namespace net { 9 namespace net {
10 10
11 FileStreamErrorParameters::FileStreamErrorParameters( 11 FileStreamErrorParameters::FileStreamErrorParameters(
12 const std::string& operation, int os_error, net::Error net_error) 12 const std::string& operation, int os_error, net::Error net_error)
13 : operation_(operation), os_error_(os_error), net_error_(net_error) { 13 : operation_(operation), os_error_(os_error), net_error_(net_error) {
14 } 14 }
15 15
16 FileStreamErrorParameters::~FileStreamErrorParameters() {}
17
16 Value* FileStreamErrorParameters::ToValue() const { 18 Value* FileStreamErrorParameters::ToValue() const {
17 DictionaryValue* dict = new DictionaryValue(); 19 DictionaryValue* dict = new DictionaryValue();
18 20
19 dict->SetString("operation", operation_); 21 dict->SetString("operation", operation_);
20 dict->SetInteger("os_error", os_error_); 22 dict->SetInteger("os_error", os_error_);
21 dict->SetInteger("net_error", net_error_); 23 dict->SetInteger("net_error", net_error_);
22 24
23 return dict; 25 return dict;
24 } 26 }
25 27
26 } // namespace net 28 } // namespace net
OLDNEW
« no previous file with comments | « net/base/file_stream_net_log_parameters.h ('k') | net/base/host_resolver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698