Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: net/http/http_pipelined_connection_impl.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_pipelined_connection_impl.h" 5 #include "net/http/http_pipelined_connection_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 21 matching lines...) Expand all
32 : source_(source), feedback_(feedback) {} 32 : source_(source), feedback_(feedback) {}
33 33
34 virtual Value* ToValue() const OVERRIDE { 34 virtual Value* ToValue() const OVERRIDE {
35 DictionaryValue* dict = new DictionaryValue; 35 DictionaryValue* dict = new DictionaryValue;
36 dict->Set("source_dependency", source_.ToValue()); 36 dict->Set("source_dependency", source_.ToValue());
37 dict->SetString("feedback", feedback_); 37 dict->SetString("feedback", feedback_);
38 return dict; 38 return dict;
39 } 39 }
40 40
41 private: 41 private:
42 virtual ~ReceivedHeadersParameters() {}
43
42 const NetLog::Source source_; 44 const NetLog::Source source_;
43 const std::string feedback_; 45 const std::string feedback_;
44 }; 46 };
45 47
46 class StreamClosedParameters : public NetLog::EventParameters { 48 class StreamClosedParameters : public NetLog::EventParameters {
47 public: 49 public:
48 StreamClosedParameters(const NetLog::Source& source, bool not_reusable) 50 StreamClosedParameters(const NetLog::Source& source, bool not_reusable)
49 : source_(source), not_reusable_(not_reusable) {} 51 : source_(source), not_reusable_(not_reusable) {}
50 52
51 virtual Value* ToValue() const OVERRIDE { 53 virtual Value* ToValue() const OVERRIDE {
52 DictionaryValue* dict = new DictionaryValue; 54 DictionaryValue* dict = new DictionaryValue;
53 dict->Set("source_dependency", source_.ToValue()); 55 dict->Set("source_dependency", source_.ToValue());
54 dict->SetBoolean("not_reusable", not_reusable_); 56 dict->SetBoolean("not_reusable", not_reusable_);
55 return dict; 57 return dict;
56 } 58 }
57 59
58 private: 60 private:
61 virtual ~StreamClosedParameters() {}
62
59 const NetLog::Source source_; 63 const NetLog::Source source_;
60 const bool not_reusable_; 64 const bool not_reusable_;
61 }; 65 };
62 66
63 } // anonymous namespace 67 } // anonymous namespace
64 68
65 HttpPipelinedConnectionImpl::HttpPipelinedConnectionImpl( 69 HttpPipelinedConnectionImpl::HttpPipelinedConnectionImpl(
66 ClientSocketHandle* connection, 70 ClientSocketHandle* connection,
67 HttpPipelinedConnection::Delegate* delegate, 71 HttpPipelinedConnection::Delegate* delegate,
68 const HostPortPair& origin, 72 const HostPortPair& origin,
(...skipping 757 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 } 830 }
827 831
828 HttpPipelinedConnectionImpl::StreamInfo::StreamInfo() 832 HttpPipelinedConnectionImpl::StreamInfo::StreamInfo()
829 : state(STREAM_CREATED) { 833 : state(STREAM_CREATED) {
830 } 834 }
831 835
832 HttpPipelinedConnectionImpl::StreamInfo::~StreamInfo() { 836 HttpPipelinedConnectionImpl::StreamInfo::~StreamInfo() {
833 } 837 }
834 838
835 } // namespace net 839 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698