RefCounted types should not have public destructors, net/

net/dns/dns_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_transaction.h"
 
 #include <deque>
 #include <string>
 #include <vector>
 
@@ skipping 46 matching lines @@
       : hostname_(hostname), qtype_(qtype) {}
 
   virtual Value* ToValue() const OVERRIDE {
     DictionaryValue* dict = new DictionaryValue();
     dict->SetString("hostname", hostname_);
     dict->SetInteger("query_type", qtype_);
     return dict;
   }
 
  private:
+  virtual ~StartParameters() {}
+
   const std::string hostname_;
   const uint16 qtype_;
 };
 
 class ResponseParameters : public NetLog::EventParameters {
  public:
   ResponseParameters(int rcode, int answer_count, const NetLog::Source& source)
       : rcode_(rcode), answer_count_(answer_count), source_(source) {}
 
   virtual Value* ToValue() const OVERRIDE {
     DictionaryValue* dict = new DictionaryValue();
     dict->SetInteger("rcode", rcode_);
     dict->SetInteger("answer_count", answer_count_);
     dict->Set("source_dependency", source_.ToValue());
     return dict;
   }
 
  private:
+  virtual ~ResponseParameters() {}
+
   const int rcode_;
   const int answer_count_;
   const NetLog::Source source_;
 };
 
 // ----------------------------------------------------------------------------
 
 // A single asynchronous DNS exchange over UDP, which consists of sending out a
 // DNS query, waiting for a response, and returning the response that it
 // matches. Logging is done in the socket and in the outer DnsTransaction.
@@ skipping 504 matching lines @@
 
 // static
 scoped_ptr<DnsTransactionFactory> DnsTransactionFactory::CreateFactory(
     DnsSession* session) {
   return scoped_ptr<DnsTransactionFactory>(
       new DnsTransactionFactoryImpl(session));
 }
 
 }  // namespace net