RefCounted types should not have public destructors, net/

net/base/default_server_bound_cert_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/default_server_bound_cert_store.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 class MockPersistentStore
     : public DefaultServerBoundCertStore::PersistentStore {
  public:
   MockPersistentStore();
-  virtual ~MockPersistentStore();
 
   // DefaultServerBoundCertStore::PersistentStore implementation.
   virtual bool Load(
       std::vector<DefaultServerBoundCertStore::ServerBoundCert*>* certs)
           OVERRIDE;
   virtual void AddServerBoundCert(
       const DefaultServerBoundCertStore::ServerBoundCert& cert) OVERRIDE;
   virtual void DeleteServerBoundCert(
       const DefaultServerBoundCertStore::ServerBoundCert& cert) OVERRIDE;
   virtual void SetClearLocalStateOnExit(bool clear_local_state) OVERRIDE;
   virtual void Flush(const base::Closure& completion_task) OVERRIDE;
 
  private:
+  virtual ~MockPersistentStore();
+
   typedef std::map<std::string, DefaultServerBoundCertStore::ServerBoundCert>
       ServerBoundCertMap;
 
   ServerBoundCertMap origin_certs_;
 };
 
 MockPersistentStore::MockPersistentStore() {}
 
 MockPersistentStore::~MockPersistentStore() {}

[eroman, 2012/04/13 18:59:34]

nit: can you move this down to match declaration order?

 
 bool MockPersistentStore::Load(
     std::vector<DefaultServerBoundCertStore::ServerBoundCert*>* certs) {
   ServerBoundCertMap::iterator it;
 
   for (it = origin_certs_.begin(); it != origin_certs_.end(); ++it) {
     certs->push_back(
         new DefaultServerBoundCertStore::ServerBoundCert(it->second));
   }
 
@@ skipping 229 matching lines @@
       base::Time(),
       "g", "h");
 
   EXPECT_EQ(4, store.GetCertCount());
   ServerBoundCertStore::ServerBoundCertList certs;
   store.GetAllServerBoundCerts(&certs);
   EXPECT_EQ(4u, certs.size());
 }
 
 }  // namespace net