Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: webkit/tools/test_shell/simple_file_writer.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/simple_file_writer.cc
diff --git a/webkit/tools/test_shell/simple_file_writer.cc b/webkit/tools/test_shell/simple_file_writer.cc
index 86be501862125da1e731eb3841e5d96a7a578560..6689bf1b4916f1a789020002f51007ef2057ff0d 100644
--- a/webkit/tools/test_shell/simple_file_writer.cc
+++ b/webkit/tools/test_shell/simple_file_writer.cc
@@ -40,9 +40,6 @@ class SimpleFileWriter::IOThreadProxy
main_thread_ = base::MessageLoopProxy::current();
}
- virtual ~IOThreadProxy() {
- }
-
void Truncate(const GURL& path, int64 offset) {
if (!io_thread_->BelongsToCurrentThread()) {
io_thread_->PostTask(
@@ -85,6 +82,9 @@ class SimpleFileWriter::IOThreadProxy
}
private:
+ friend class base::RefCountedThreadSafe<IOThreadProxy>;
+ virtual ~IOThreadProxy() {}
+
FileSystemOperationInterface* GetNewOperation(const GURL& path) {
return file_system_context_->CreateFileSystemOperation(path, io_thread_);
}
« no previous file with comments | « webkit/support/test_webmessageportchannel.cc ('k') | webkit/tools/test_shell/simple_resource_loader_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698