Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: webkit/appcache/appcache_storage_unittest.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_storage_impl_unittest.cc ('k') | webkit/appcache/appcache_update_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_storage_unittest.cc
diff --git a/webkit/appcache/appcache_storage_unittest.cc b/webkit/appcache/appcache_storage_unittest.cc
index 82e3b99c3f5e0890fa91c8bdc0ca091d6abce1fb..f2ddce1c03aae7d18426e531f952d64fef0d1c60 100644
--- a/webkit/appcache/appcache_storage_unittest.cc
+++ b/webkit/appcache/appcache_storage_unittest.cc
@@ -24,11 +24,12 @@ class AppCacheStorageTest : public testing::Test {
: QuotaManagerProxy(NULL, NULL),
notify_storage_accessed_count_(0),
notify_storage_modified_count_(0),
- last_delta_(0) {}
+ last_delta_(0) {
+ }
virtual void NotifyStorageAccessed(quota::QuotaClient::ID client_id,
const GURL& origin,
- quota::StorageType type) {
+ quota::StorageType type) OVERRIDE {
EXPECT_EQ(quota::QuotaClient::kAppcache, client_id);
EXPECT_EQ(quota::kStorageTypeTemporary, type);
++notify_storage_accessed_count_;
@@ -38,7 +39,7 @@ class AppCacheStorageTest : public testing::Test {
virtual void NotifyStorageModified(quota::QuotaClient::ID client_id,
const GURL& origin,
quota::StorageType type,
- int64 delta) {
+ int64 delta) OVERRIDE {
EXPECT_EQ(quota::QuotaClient::kAppcache, client_id);
EXPECT_EQ(quota::kStorageTypeTemporary, type);
++notify_storage_modified_count_;
@@ -47,14 +48,17 @@ class AppCacheStorageTest : public testing::Test {
}
// Not needed for our tests.
- virtual void RegisterClient(quota::QuotaClient* client) {}
- virtual void NotifyOriginInUse(const GURL& origin) {}
- virtual void NotifyOriginNoLongerInUse(const GURL& origin) {}
+ virtual void RegisterClient(quota::QuotaClient* client) OVERRIDE {}
+ virtual void NotifyOriginInUse(const GURL& origin) OVERRIDE {}
+ virtual void NotifyOriginNoLongerInUse(const GURL& origin) OVERRIDE {}
int notify_storage_accessed_count_;
int notify_storage_modified_count_;
GURL last_origin_;
int last_delta_;
+
+ protected:
+ virtual ~MockQuotaManagerProxy() {}
};
};
« no previous file with comments | « webkit/appcache/appcache_storage_impl_unittest.cc ('k') | webkit/appcache/appcache_update_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698