Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: webkit/database/databases_table_unittest.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/database/database_tracker_unittest.cc ('k') | webkit/database/quota_table_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_util.h" 5 #include "base/string_util.h"
6 #include "base/utf_string_conversions.h" 6 #include "base/utf_string_conversions.h"
7 #include "sql/connection.h" 7 #include "sql/connection.h"
8 #include "sql/statement.h" 8 #include "sql/statement.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "webkit/database/databases_table.h" 10 #include "webkit/database/databases_table.h"
11 11
12 namespace { 12 namespace {
13 13
14 class TestErrorDelegate : public sql::ErrorDelegate { 14 class TestErrorDelegate : public sql::ErrorDelegate {
15 public: 15 public:
16 virtual ~TestErrorDelegate() { } 16 virtual int OnError(int error,
17 virtual int OnError( 17 sql::Connection* connection,
18 int error, sql::Connection* connection, sql::Statement* stmt) { 18 sql::Statement* stmt) OVERRIDE {
19 return error; 19 return error;
20 } 20 }
21
22 protected:
23 virtual ~TestErrorDelegate() {}
21 }; 24 };
22 25
23 } // namespace 26 } // namespace
24 27
25 namespace webkit_database { 28 namespace webkit_database {
26 29
27 static void CheckDetailsAreEqual(const DatabaseDetails& d1, 30 static void CheckDetailsAreEqual(const DatabaseDetails& d1,
28 const DatabaseDetails& d2) { 31 const DatabaseDetails& d2) {
29 EXPECT_EQ(d1.origin_identifier, d2.origin_identifier); 32 EXPECT_EQ(d1.origin_identifier, d2.origin_identifier);
30 EXPECT_EQ(d1.database_name, d2.database_name); 33 EXPECT_EQ(d1.database_name, d2.database_name);
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 details_in1.origin_identifier, 145 details_in1.origin_identifier,
143 details_in1.database_name, 146 details_in1.database_name,
144 &details_out1)); 147 &details_out1));
145 148
146 // Check that trying to delete a record that doesn't exist fails. 149 // Check that trying to delete a record that doesn't exist fails.
147 EXPECT_FALSE(databases_table.DeleteDatabaseDetails( 150 EXPECT_FALSE(databases_table.DeleteDatabaseDetails(
148 ASCIIToUTF16("unknown_origin"), ASCIIToUTF16("unknown_database"))); 151 ASCIIToUTF16("unknown_origin"), ASCIIToUTF16("unknown_database")));
149 } 152 }
150 153
151 } // namespace webkit_database 154 } // namespace webkit_database
OLDNEW
« no previous file with comments | « webkit/database/database_tracker_unittest.cc ('k') | webkit/database/quota_table_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698