Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: webkit/appcache/appcache_service.h

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_APPCACHE_APPCACHE_SERVICE_H_ 5 #ifndef WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
6 #define WEBKIT_APPCACHE_APPCACHE_SERVICE_H_ 6 #define WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 10
(...skipping 25 matching lines...) Expand all
36 namespace appcache { 36 namespace appcache {
37 37
38 class AppCacheBackendImpl; 38 class AppCacheBackendImpl;
39 class AppCacheQuotaClient; 39 class AppCacheQuotaClient;
40 class AppCachePolicy; 40 class AppCachePolicy;
41 41
42 // Refcounted container to avoid copying the collection in callbacks. 42 // Refcounted container to avoid copying the collection in callbacks.
43 struct APPCACHE_EXPORT AppCacheInfoCollection 43 struct APPCACHE_EXPORT AppCacheInfoCollection
44 : public base::RefCountedThreadSafe<AppCacheInfoCollection> { 44 : public base::RefCountedThreadSafe<AppCacheInfoCollection> {
45 AppCacheInfoCollection(); 45 AppCacheInfoCollection();
46 virtual ~AppCacheInfoCollection();
47 46
48 std::map<GURL, AppCacheInfoVector> infos_by_origin; 47 std::map<GURL, AppCacheInfoVector> infos_by_origin;
48
49 private:
50 friend class base::RefCountedThreadSafe<AppCacheInfoCollection>;
51 virtual ~AppCacheInfoCollection();
49 }; 52 };
50 53
51 // Class that manages the application cache service. Sends notifications 54 // Class that manages the application cache service. Sends notifications
52 // to many frontends. One instance per user-profile. Each instance has 55 // to many frontends. One instance per user-profile. Each instance has
53 // exclusive access to its cache_directory on disk. 56 // exclusive access to its cache_directory on disk.
54 class APPCACHE_EXPORT AppCacheService { 57 class APPCACHE_EXPORT AppCacheService {
55 public: 58 public:
56 // If not using quota management, the proxy may be NULL. 59 // If not using quota management, the proxy may be NULL.
57 explicit AppCacheService(quota::QuotaManagerProxy* quota_manager_proxy); 60 explicit AppCacheService(quota::QuotaManagerProxy* quota_manager_proxy);
58 virtual ~AppCacheService(); 61 virtual ~AppCacheService();
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 bool clear_local_state_on_exit_; 183 bool clear_local_state_on_exit_;
181 // If true, nothing (not even session-only data) should be deleted on exit. 184 // If true, nothing (not even session-only data) should be deleted on exit.
182 bool save_session_state_; 185 bool save_session_state_;
183 186
184 DISALLOW_COPY_AND_ASSIGN(AppCacheService); 187 DISALLOW_COPY_AND_ASSIGN(AppCacheService);
185 }; 188 };
186 189
187 } // namespace appcache 190 } // namespace appcache
188 191
189 #endif // WEBKIT_APPCACHE_APPCACHE_SERVICE_H_ 192 #endif // WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
OLDNEW
« no previous file with comments | « webkit/appcache/appcache_request_handler_unittest.cc ('k') | webkit/appcache/appcache_storage_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698