Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: remoting/protocol/buffered_socket_writer.cc

Issue 10066042: Refcounted types should not have public destructors, remoting/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Few fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/buffered_socket_writer.h ('k') | remoting/protocol/message_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/buffered_socket_writer.cc
diff --git a/remoting/protocol/buffered_socket_writer.cc b/remoting/protocol/buffered_socket_writer.cc
index b05f467dc5862f8c7ed58715e6476fe6185ad7f5..13e62a241dc5f6ae5c151b96715a19c8cc4cd8af 100644
--- a/remoting/protocol/buffered_socket_writer.cc
+++ b/remoting/protocol/buffered_socket_writer.cc
@@ -45,8 +45,6 @@ BufferedSocketWriterBase::BufferedSocketWriterBase(
closed_(false) {
}
-BufferedSocketWriterBase::~BufferedSocketWriterBase() { }
-
void BufferedSocketWriterBase::Init(net::Socket* socket,
const WriteFailedCallback& callback) {
DCHECK(message_loop_->BelongsToCurrentThread());
@@ -159,6 +157,8 @@ void BufferedSocketWriterBase::Close() {
closed_ = true;
}
+BufferedSocketWriterBase::~BufferedSocketWriterBase() {}
+
void BufferedSocketWriterBase::PopQueue() {
// This also calls |done_task|.
delete queue_.front();
@@ -170,10 +170,6 @@ BufferedSocketWriter::BufferedSocketWriter(
: BufferedSocketWriterBase(message_loop) {
}
-BufferedSocketWriter::~BufferedSocketWriter() {
- STLDeleteElements(&queue_);
-}
-
void BufferedSocketWriter::GetNextPacket_Locked(
net::IOBuffer** buffer, int* size) {
if (!current_buf_) {
@@ -203,11 +199,14 @@ void BufferedSocketWriter::OnError_Locked(int result) {
current_buf_ = NULL;
}
+BufferedSocketWriter::~BufferedSocketWriter() {
+ STLDeleteElements(&queue_);
+}
+
BufferedDatagramWriter::BufferedDatagramWriter(
base::MessageLoopProxy* message_loop)
: BufferedSocketWriterBase(message_loop) {
}
-BufferedDatagramWriter::~BufferedDatagramWriter() { }
void BufferedDatagramWriter::GetNextPacket_Locked(
net::IOBuffer** buffer, int* size) {
@@ -229,5 +228,7 @@ void BufferedDatagramWriter::OnError_Locked(int result) {
// Nothing to do here.
}
+BufferedDatagramWriter::~BufferedDatagramWriter() {}
+
} // namespace protocol
} // namespace remoting
« no previous file with comments | « remoting/protocol/buffered_socket_writer.h ('k') | remoting/protocol/message_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698