Issue 10066042: Refcounted types should not have public destructors, remoting/ edition

Issue 10066042: Refcounted types should not have public destructors, remoting/ edition (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi

Modified:
8 years, 8 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refcounted types should not have public destructors, remoting/ edition BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133801

Patch Set 1 #

Patch Set 2 : Implementation files #

Patch Set 3 : Few fixes #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -39 lines)			Patch
M	remoting/base/capture_data.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/client/frame_consumer_proxy.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	remoting/client/frame_consumer_proxy.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/client/rectangle_update_decoder.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/host/differ_block_unittest.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	remoting/host/gaia_oauth_client.cc	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	remoting/host/screen_recorder.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	remoting/host/screen_recorder.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/protocol/buffered_socket_writer.h	View	1 2	4 chunks	+9 lines, -3 lines	0 comments	Download
M	remoting/protocol/buffered_socket_writer.cc	View	1	5 chunks	+8 lines, -7 lines	0 comments	Download
M	remoting/protocol/message_reader.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	remoting/protocol/message_reader.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10066042/1

8 years, 8 months ago (2012-04-14 01:24:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10066042/12001

8 years, 8 months ago (2012-04-24 21:46:40 UTC) #5

Change committed as 133801

Expand Messages | Collapse Messages