Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10066015: ash: Replace launcher app type with Extension launch type. (Closed)

Created:
8 years, 8 months ago by xiyuan
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, sadrul, mihaip+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Replace launcher app type with Extension launch type. And update launcher context menu. BUG=122428, 120472 TEST=Verify fix for issue 122428 and 120472. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132148

Patch Set 1 #

Patch Set 2 : fix launcher_updater_unittest compile #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -154 lines) Patch
M chrome/browser/ui/views/ash/app_list/extension_app_item.cc View 3 chunks +6 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.h View 7 chunks +9 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc View 12 chunks +37 lines, -76 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_context_menu.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc View 1 2 4 chunks +26 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_updater.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_updater_unittest.cc View 1 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
xiyuan
8 years, 8 months ago (2012-04-12 16:55:12 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-12 17:59:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10066015/5001
8 years, 8 months ago (2012-04-12 21:16:34 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc ...
8 years, 8 months ago (2012-04-12 21:16:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10066015/10001
8 years, 8 months ago (2012-04-12 21:38:24 UTC) #5
commit-bot: I haz the power
Try job failure for 10066015-10001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-13 01:08:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10066015/10001
8 years, 8 months ago (2012-04-13 05:02:14 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 06:21:05 UTC) #8
Change committed as 132148

Powered by Google App Engine
This is Rietveld 408576698