Modify IsSyncable to only include Internal items and the Chrome Web Store

Modify IsSyncable to only include Internal items and the Chrome Web Store

Modify IsSyncable to stop syncing all applications, as this is incorrect syncing Chrome OS default applications.


BUG=121929
TEST=Only internal extension, applications and the chrome web store should be syncing (i.e. default Chrome OS should no longer sync)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132065

[Finnur, 2012-04-12 15:01:40]

LGTM

https://chromiumcodereview.appspot.com/10066014/diff/1/chrome/common/extensio...
File chrome/common/extensions/extension.cc (right):

https://chromiumcodereview.appspot.com/10066014/diff/1/chrome/common/extensio...
chrome/common/extensions/extension.cc:3663: // multiple machines, and the chrome
web store.
nit: 'and should appear on multiple machines' is either redundant or you are
missing further checks in the return statement...

[csharp, 2012-04-12 15:06:29]

https://chromiumcodereview.appspot.com/10066014/diff/1/chrome/common/extensio...
File chrome/common/extensions/extension.cc (right):

https://chromiumcodereview.appspot.com/10066014/diff/1/chrome/common/extensio...
chrome/common/extensions/extension.cc:3663: // multiple machines, and the chrome
web store.
On 2012/04/12 15:01:40, Finnur wrote:
> nit: 'and should appear on multiple machines' is either redundant or you are
> missing further checks in the return statement...

Done.

[commit-bot: I haz the power, 2012-04-12 15:06:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/10066014/2002

[commit-bot: I haz the power, 2012-04-12 18:13:30]

Try job failure for 10066014-2002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-12 18:14:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/10066014/2002

[commit-bot: I haz the power, 2012-04-12 19:58:07]

Try job failure for 10066014-2002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-12 20:01:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/10066014/2002

[commit-bot: I haz the power, 2012-04-12 21:35:18]

Change committed as 132065