Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: chrome/browser/protector/base_setting_change.h

Issue 10066013: [protector] Homepage UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: License update. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/protector/base_setting_change.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/protector/base_setting_change.h
diff --git a/chrome/browser/protector/base_setting_change.h b/chrome/browser/protector/base_setting_change.h
index 9aa6c84bc695110b116d0bd0c93e0640c93da782..14af703aa74715103e6284692f33f7ac66acf05f 100644
--- a/chrome/browser/protector/base_setting_change.h
+++ b/chrome/browser/protector/base_setting_change.h
@@ -108,6 +108,11 @@ class BaseSettingChange {
// Returns true if this change can be merged with other changes.
virtual bool CanBeMerged() const;
+ // Returns |false| if this change is not user-visible. It won't be presented
+ // to user on it's own then, but may be merged with other changes and applied
+ // or discarded.
+ virtual bool IsUserVisible() const;
+
protected:
// Profile instance we've been associated with by an |Init| call.
Profile* profile() { return profile_; }
@@ -121,6 +126,7 @@ class BaseSettingChange {
// Display name priorities of various change types:
extern const size_t kDefaultSearchProviderChangeNamePriority;
extern const size_t kSessionStartupChangeNamePriority;
+extern const size_t kHomepageChangeNamePriority;
// TODO(ivankr): CompositeSettingChange that incapsulates multiple
// BaseSettingChange instances.
@@ -142,6 +148,14 @@ BaseSettingChange* CreateSessionStartupChange(
const SessionStartupPref& backup_startup_pref,
const PinnedTabCodec::Tabs& backup_pinned_tabs);
+BaseSettingChange* CreateHomepageChange(
+ const std::string& actual_homepage,
+ bool actual_homepage_is_ntp,
+ bool actual_show_homepage,
+ const std::string& backup_homepage,
+ bool backup_homepage_is_ntp,
+ bool backup_show_homepage);
+
// Allocates and initializes BaseSettingChange implementation for an unknown
// preferences change with invalid backup.
BaseSettingChange* CreatePrefsBackupInvalidChange();
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/protector/base_setting_change.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698