[protector] Homepage UI.

[protector] Homepage UI.


BUG=114298
TEST=Manual, protector.py


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132566

[Ivan Korotkov, 2012-04-16 16:45:06]

Please take a look:
sky: protector, ui
nirnimesh: pyauto

[sky, 2012-04-16 21:07:43]

LGTM

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/protector/ho...
File chrome/browser/protector/homepage_change.cc (right):

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/protector/ho...
chrome/browser/protector/homepage_change.cc:23: kHomepageNtp = 0,
In chrome makes enums UPPER_CASE.

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/protector/ho...
chrome/browser/protector/homepage_change.cc:61: std::string new_homepage_;
Make all thse const.

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/search_engin...
File chrome/browser/search_engines/template_url_service.cc (right):

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/search_engin...
chrome/browser/search_engines/template_url_service.cc:675: } else if
(service_.get()) {
Remove this.

[Nirnimesh, 2012-04-16 21:10:29]

pyauto test LGTM

http://codereview.chromium.org/10066013/diff/4011/chrome/test/functional/prot...
File chrome/test/functional/protector.py (right):

http://codereview.chromium.org/10066013/diff/4011/chrome/test/functional/prot...
chrome/test/functional/protector.py:196: #input('Pause')
remove

[Ivan Korotkov, 2012-04-17 09:54:10]

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/protector/ho...
File chrome/browser/protector/homepage_change.cc (right):

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/protector/ho...
chrome/browser/protector/homepage_change.cc:23: kHomepageNtp = 0,
On 2012/04/16 21:07:43, sky wrote:
> In chrome makes enums UPPER_CASE.

Done.

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/protector/ho...
chrome/browser/protector/homepage_change.cc:61: std::string new_homepage_;
On 2012/04/16 21:07:43, sky wrote:
> Make all thse const.

Done.

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/search_engin...
File chrome/browser/search_engines/template_url_service.cc (right):

http://codereview.chromium.org/10066013/diff/4011/chrome/browser/search_engin...
chrome/browser/search_engines/template_url_service.cc:675: } else if
(service_.get()) {
On 2012/04/16 21:07:43, sky wrote:
> Remove this.

Oops, removed.

http://codereview.chromium.org/10066013/diff/4011/chrome/test/functional/prot...
File chrome/test/functional/protector.py (right):

http://codereview.chromium.org/10066013/diff/4011/chrome/test/functional/prot...
chrome/test/functional/protector.py:196: #input('Pause')
On 2012/04/16 21:10:29, Nirnimesh wrote:
> remove

Done.

[commit-bot: I haz the power, 2012-04-17 09:56:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10066013/12001

[commit-bot: I haz the power, 2012-04-17 09:56:37]

Presubmit check for 10066013-12001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  chrome/browser/protector/homepage_change_unittest.cc

Presubmit checks took 1.4s to calculate.

[commit-bot: I haz the power, 2012-04-17 09:59:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10066013/7002

[commit-bot: I haz the power, 2012-04-17 12:00:20]

Change committed as 132566