Issue 10066009: Remove CheckNotRegistersEqual regexp-masm function from all architectures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10066009: Remove CheckNotRegistersEqual regexp-masm function from all architectures. (Closed)

Created:
8 years, 8 months ago by kalmard

Modified:
8 years, 5 months ago

Reviewers:
kisg, Paul Lind, Erik Corry, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove CheckNotRegistersEqual regexp-masm function from all architectures. This is based on a suggestion at http://codereview.chromium.org/9721011/ and can be landed on top of that change. BUG= TEST=

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -67 lines)			Patch
M	src/arm/regexp-macro-assembler-arm.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/regexp-macro-assembler-arm.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/ia32/regexp-macro-assembler-ia32.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ia32/regexp-macro-assembler-ia32.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/regexp-macro-assembler.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/regexp-macro-assembler-irregexp.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/regexp-macro-assembler-tracer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/regexp-macro-assembler-tracer.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Committed as 11721.  Thanks, and sorry for the delay.

Expand Messages | Collapse Messages