Partial fix for crbug.com/120597. Send the current cursor location when one of the Japanese IMEs is

Partial fix for crbug.com/120597. Send the current cursor location when one of the Japanese IMEs is enabled.

Without the fix, for example, the suggestion window could be shown in a wrong place in step #6 below:

1. switch to mozc, the Japanese IME.
2. press a, press Enter.
3. repeat step #2 several times so that 'あ' is suggested when a is pressed.
4. focus text area.
5. switch to US-Qwerty, type aaaaa
6. switch to mozc, type a. The suggestion window could be shown in a wrong position because cursor location information is not sent to the IME in step #5.

BUG=120597
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132389

[Seigo Nonaka, 2012-04-13 04:15:02]

LTGM.
Thank you for your follow up.

[Seigo Nonaka, 2012-04-13 04:15:06]

lgtm

[Yusuke Sato, 2012-04-16 06:45:22]

+mukai (Chrome committer who knows Mozc details)

[Jun Mukai, 2012-04-16 06:57:53]

lgtm

The code itself is looking good.  A nitpick only and you can ignore this.

http://codereview.chromium.org/10066008/diff/7001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/ibus_ui_controller.h (right):

http://codereview.chromium.org/10066008/diff/7001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/ibus_ui_controller.h:27: typedef
std::vector<InputMethodDescriptor> InputMethodDescriptors;
Can we add this typedef here?  The definition of InputMethodDescriptors should
belong to input_method_descriptor.h, and actually it does already.  I prefer to
include input_method_descriptor.h in this file rather than duplicated typedefs,
in case that you changed your mind to use another container.  But, it's up to
you.

[commit-bot: I haz the power, 2012-04-16 07:13:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10066008/7001

[Yusuke Sato, 2012-04-16 07:15:14]

Feel free to fix it yourself if needed (after
http://codereview.chromium.org/9999018/ is landed.)  I don't have any preference
on this, and our style guide doesn't either.


On 2012/04/16 06:57:53, Jun Mukai wrote:
> lgtm
> 
> The code itself is looking good.  A nitpick only and you can ignore this.
> 
>
http://codereview.chromium.org/10066008/diff/7001/chrome/browser/chromeos/inp...
> File chrome/browser/chromeos/input_method/ibus_ui_controller.h (right):
> 
>
http://codereview.chromium.org/10066008/diff/7001/chrome/browser/chromeos/inp...
> chrome/browser/chromeos/input_method/ibus_ui_controller.h:27: typedef
> std::vector<InputMethodDescriptor> InputMethodDescriptors;
> Can we add this typedef here?  The definition of InputMethodDescriptors should
> belong to input_method_descriptor.h, and actually it does already.  I prefer
to
> include input_method_descriptor.h in this file rather than duplicated
typedefs,
> in case that you changed your mind to use another container.  But, it's up to
> you.