Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: chrome/common/persistent_pref_store.h

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/persistent_pref_store.h
diff --git a/chrome/common/persistent_pref_store.h b/chrome/common/persistent_pref_store.h
index 8b8b87b6f1c4ad16052582957adc76bafce67e4d..94083443d90b73415db0e606575a1739a669ce2d 100644
--- a/chrome/common/persistent_pref_store.h
+++ b/chrome/common/persistent_pref_store.h
@@ -15,8 +15,6 @@
// the data to some backing store.
class PersistentPrefStore : public PrefStore {
public:
- virtual ~PersistentPrefStore() {}
-
// Unique integer code for each type of error so we can report them
// distinctly in a histogram.
// NOTE: Don't change the order here as it will change the server's meaning
@@ -89,6 +87,9 @@ class PersistentPrefStore : public PrefStore {
// Lands any pending writes to disk.
virtual void CommitPendingWrite() = 0;
+
+ protected:
+ virtual ~PersistentPrefStore() {}
};
#endif // CHROME_COMMON_PERSISTENT_PREF_STORE_H_

Powered by Google App Engine
This is Rietveld 408576698