Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7336)

Unified Diff: chrome/common/net/gaia/gaia_oauth_client.cc

Issue 10065040: RefCounted types should not have public destructors, chrome/ remaining parts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/net/gaia/gaia_oauth_client.cc
diff --git a/chrome/common/net/gaia/gaia_oauth_client.cc b/chrome/common/net/gaia/gaia_oauth_client.cc
index eb4179dda5ddef7220e43b7d51cc26b34a6908c1..d657b3fa5e6c300d2ac5221aaabaac104764fa2d 100644
--- a/chrome/common/net/gaia/gaia_oauth_client.cc
+++ b/chrome/common/net/gaia/gaia_oauth_client.cc
@@ -34,8 +34,6 @@ class GaiaOAuthClient::Core
request_context_getter_(request_context_getter),
delegate_(NULL) {}
- virtual ~Core() { }
-
void GetTokensFromAuthCode(const OAuthClientInfo& oauth_client_info,
const std::string& auth_code,
int max_retries,
@@ -49,6 +47,9 @@ class GaiaOAuthClient::Core
virtual void OnURLFetchComplete(const content::URLFetcher* source);
private:
+ friend class base::RefCountedThreadSafe<Core>;
+ virtual ~Core() {}
+
void MakeGaiaRequest(std::string post_body,
int max_retries,
GaiaOAuthClient::Delegate* delegate);

Powered by Google App Engine
This is Rietveld 408576698