RefCounted types should not have public destructors, base/ edition

base/files/file_path_watcher_kqueue.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path_watcher.h"
 
 #include <fcntl.h>
 #include <sys/event.h>
 #include <sys/param.h>
 
@@ skipping 36 matching lines @@
 // The kqueue implementation will handle all of the items in the list above
 // except for detecting modifications to files in a watched directory. It will
 // detect the creation and deletion of files, just not the modification of
 // files. It does however detect the attribute changes that the FSEvents impl
 // would miss.
 class FilePathWatcherImpl : public FilePathWatcher::PlatformDelegate,
                             public MessageLoopForIO::Watcher,
                             public MessageLoop::DestructionObserver {
  public:
   FilePathWatcherImpl() : kqueue_(-1) {}
-  virtual ~FilePathWatcherImpl() {}
 
   // MessageLoopForIO::Watcher overrides.
   virtual void OnFileCanReadWithoutBlocking(int fd) OVERRIDE;
   virtual void OnFileCanWriteWithoutBlocking(int fd) OVERRIDE;
 
   // MessageLoop::DestructionObserver overrides.
   virtual void WillDestroyCurrentMessageLoop() OVERRIDE;
 
   // FilePathWatcher::PlatformDelegate overrides.
   virtual bool Watch(const FilePath& path,
                      FilePathWatcher::Delegate* delegate) OVERRIDE;
   virtual void Cancel() OVERRIDE;
 
  private:
+  virtual ~FilePathWatcherImpl() {}
+
   class EventData {
    public:
     EventData(const FilePath& path, const FilePath::StringType& subdir)
         : path_(path), subdir_(subdir) { }
     FilePath path_;  // Full path to this item.
     FilePath::StringType subdir_;  // Path to any sub item.
   };
   typedef std::vector<struct kevent> EventVector;
 
   // Can only be called on |io_message_loop_|'s thread.
@@ skipping 411 matching lines @@
 }
 
 }  // namespace
 
 FilePathWatcher::FilePathWatcher() {
   impl_ = new FilePathWatcherImpl();
 }
 
 }  // namespace files
 }  // namespace base