Temporarily make unit_tests a static library on Android.

Temporarily make unit_tests a static library on Android.

While we sort out the remaining linker errors, this at least ensures we
can add compliation of a bunch of chrome code for Android to gatekeeper.
This is motivated by having the android unit_tests compilation step
broken 4 out of 4 days this week.

BUG=117407
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132154

[Yaron, 2012-04-12 17:02:54]

We can stage it on the experimental FYI bot and then add to gatekeeper later
today if it goes through. This depends on
http://codereview.chromium.org/10071015/ which fixes today's breakage.

[John Grabowski, 2012-04-12 17:51:57]

http://codereview.chromium.org/10065018/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/10065018/diff/1/chrome/chrome_tests.gypi#newco...
chrome/chrome_tests.gypi:2445: 'type': 'static_library',
plz wrap this in another gyp variable that has a default setting so we can
switch back and forth with a re-gyp instead of editing this file

happy to have default be "static library" for now

[Yaron, 2012-04-12 19:50:30]

http://codereview.chromium.org/10065018/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/10065018/diff/1/chrome/chrome_tests.gypi#newco...
chrome/chrome_tests.gypi:2445: 'type': 'static_library',
On 2012/04/12 17:51:58, John Grabowski wrote:
> plz wrap this in another gyp variable that has a default setting so we can
> switch back and forth with a re-gyp instead of editing this file
> 
> happy to have default be "static library" for now

Done.

[John Grabowski, 2012-04-12 20:12:01]

LGTM

http://codereview.chromium.org/10065018/diff/2002/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/10065018/diff/2002/build/common.gypi#newcode849
build/common.gypi:849: # TODO(yfriedman): Remove once unit_tests can link for
Android.
Add comment with the exact command line to override.
E.g.
GYP_DEFINES="$GYP_DEFINES android_unit_test_target_type=executable" android_gyp

[commit-bot: I haz the power, 2012-04-12 20:23:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10065018/5002

[commit-bot: I haz the power, 2012-04-12 22:15:10]

Try job failure for 10065018-5002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-12 22:26:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10065018/5002

[commit-bot: I haz the power, 2012-04-13 01:37:00]

Try job failure for 10065018-5002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-13 01:37:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10065018/5002

[commit-bot: I haz the power, 2012-04-13 03:49:41]

Try job failure for 10065018-5002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-13 05:06:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10065018/5002

[commit-bot: I haz the power, 2012-04-13 07:37:16]

Change committed as 132154