Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10065017: TabContents -> WebContentsImpl, part 8. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 8. "Detab" content/browser/debugger. BUG=105875 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -74 lines) Patch
M chrome/browser/debugger/devtools_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_debugger_api.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_frontend_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/debugger/devtools_frontend_host.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/debugger/devtools_manager_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/debugger/devtools_manager_impl.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M content/browser/debugger/render_view_devtools_agent_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/devtools_client_host.h View 1 chunk +7 lines, -8 lines 0 comments Download
M content/public/browser/devtools_frontend_host_delegate.h View 2 chunks +10 lines, -9 lines 0 comments Download
M content/public/browser/devtools_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-12 16:46:13 UTC) #1
jam
lgtm
8 years, 8 months ago (2012-04-12 16:58:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10065017/1
8 years, 8 months ago (2012-04-12 19:06:37 UTC) #3
commit-bot: I haz the power
Presubmit check for 10065017-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-12 19:06:46 UTC) #4
Ben Goodger (Google)
LGTM
8 years, 8 months ago (2012-04-12 19:49:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10065017/1
8 years, 8 months ago (2012-04-12 19:50:19 UTC) #6
commit-bot: I haz the power
Try job failure for 10065017-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-12 23:21:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10065017/1
8 years, 8 months ago (2012-04-13 14:22:18 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 15:48:12 UTC) #9 
Change committed as 132193

Powered by Google App Engine
This is Rietveld 408576698