[protector] Refactoring of --no-protector code.

chrome/browser/protector/base_setting_change.h

Index: chrome/browser/protector/base_setting_change.h
diff --git a/chrome/browser/protector/base_setting_change.h b/chrome/browser/protector/base_setting_change.h
index 05e680bbfa851ecb1c76b69745e72bbebe7db45d..9aa6c84bc695110b116d0bd0c93e0640c93da782 100644
--- a/chrome/browser/protector/base_setting_change.h
+++ b/chrome/browser/protector/base_setting_change.h
@@ -55,6 +55,10 @@ class BaseSettingChange {
   // base method.
   virtual bool Init(Profile* profile);
 
+  // Called instead of Init when ProtectorService is disabled. No other members
+  // are called in that case.
+  virtual void InitWhenDisabled(Profile* profile);

[sky, 2012/04/13 19:25:13]

It feels error prone to have the two distinct Init variants. How about passing
an enum to Init?

[Ivan Korotkov, 2012/04/13 20:16:38]

I specifically made them distinct functions because they do completely different
things and act in completely different scenarios (one is
Init-getters-Apply/Discard, the other just InitWhileDisabled).

+
   // Persists new setting if needed. |browser| is the Browser instance from
   // which the user action originates.
   virtual void Apply(Browser* browser);