Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10065016: [protector] Refactoring of --no-protector code. (Closed)

Created:
8 years, 8 months ago by Ivan Korotkov
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

[protector] Refactoring of --no-protector code. *) On DSE change, new provider is not pushed to Sync. *) Simplified code in BrowserInit. BUG=None TEST=protector.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132398

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Refactoring #

Patch Set 4 : Mock fix #

Total comments: 6

Patch Set 5 : Merge #

Patch Set 6 : Fixes #

Patch Set 7 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -28 lines) Patch
M chrome/browser/protector/base_prefs_change.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/protector/base_prefs_change.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/protector/base_setting_change.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/protector/base_setting_change.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/protector/default_search_provider_change.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/protector/histograms.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/protector/mock_setting_change.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/protector/prefs_backup_invalid_change.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/protector/protected_prefs_watcher.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/protector/protected_prefs_watcher.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/protector/protector_service.cc View 1 2 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ivan Korotkov
Hi Scott, this CL simplifies the --no-protector case handling in browser_init and also fixes a ...
8 years, 8 months ago (2012-04-13 11:12:31 UTC) #1
sky
The browser_init changes are fine. http://codereview.chromium.org/10065016/diff/8002/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): http://codereview.chromium.org/10065016/diff/8002/chrome/browser/search_engines/template_url_service.cc#newcode675 chrome/browser/search_engines/template_url_service.cc:675: } else if (service_.get()) ...
8 years, 8 months ago (2012-04-13 15:56:22 UTC) #2
Ivan Korotkov
Since Anton is no longer in Chrome team and has little time for code reviews ...
8 years, 8 months ago (2012-04-13 17:19:10 UTC) #3
sky
http://codereview.chromium.org/10065016/diff/8002/chrome/browser/protector/base_setting_change.h File chrome/browser/protector/base_setting_change.h (right): http://codereview.chromium.org/10065016/diff/8002/chrome/browser/protector/base_setting_change.h#newcode60 chrome/browser/protector/base_setting_change.h:60: virtual void InitWhenDisabled(Profile* profile); It feels error prone to ...
8 years, 8 months ago (2012-04-13 19:25:13 UTC) #4
Ivan Korotkov
http://codereview.chromium.org/10065016/diff/8002/chrome/browser/protector/base_setting_change.h File chrome/browser/protector/base_setting_change.h (right): http://codereview.chromium.org/10065016/diff/8002/chrome/browser/protector/base_setting_change.h#newcode60 chrome/browser/protector/base_setting_change.h:60: virtual void InitWhenDisabled(Profile* profile); On 2012/04/13 19:25:13, sky wrote: ...
8 years, 8 months ago (2012-04-13 20:16:38 UTC) #5
sky
Everything else looks good. http://codereview.chromium.org/10065016/diff/8002/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): http://codereview.chromium.org/10065016/diff/8002/chrome/browser/search_engines/template_url_service.cc#newcode675 chrome/browser/search_engines/template_url_service.cc:675: } else if (service_.get()) { ...
8 years, 8 months ago (2012-04-13 21:33:39 UTC) #6
Ivan Korotkov
http://codereview.chromium.org/10065016/diff/8002/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): http://codereview.chromium.org/10065016/diff/8002/chrome/browser/search_engines/template_url_service.cc#newcode675 chrome/browser/search_engines/template_url_service.cc:675: } else if (service_.get()) { On 2012/04/13 21:33:39, sky ...
8 years, 8 months ago (2012-04-13 22:06:32 UTC) #7
sky
LGTM
8 years, 8 months ago (2012-04-13 22:49:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10065016/18001
8 years, 8 months ago (2012-04-16 11:07:01 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 13:53:40 UTC) #10 
Change committed as 132398

Powered by Google App Engine
This is Rietveld 408576698