Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 10065004: chromeos: Update static chrome://os-credits page for R19 (Closed)

Created:
8 years, 8 months ago by ferringb
Modified:
8 years, 8 months ago
Reviewers:
oritm, Daniel Erat, zel
CC:
chromium-reviews
Visibility:
Public.

Description

chromeos: Update static chrome://os-credits page for R19 BUG=chromium-os:25279 TEST=visual inspection of changes since R18 TBR=zelidrag Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133609

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2729 lines, -5625 lines) Patch
M about_os_credits.html View 46 chunks +2729 lines, -5625 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
ferringb
For ease of review, I've uploaded a `git diff --patience` version of this to http://paste.pocoo.org/show/579856/ ...
8 years, 8 months ago (2012-04-12 03:31:34 UTC) #1
zel
8 years, 8 months ago (2012-04-23 21:43:41 UTC) #2
Daniel Erat
LGTM Do you need me to commit this and merge it?
8 years, 8 months ago (2012-04-23 21:56:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ferringb@google.com/10065004/1
8 years, 8 months ago (2012-04-23 21:57:05 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/resources/chromeos/about_os_credits.html. While running svn propset svn:eol-style LF chrome/browser/resources/chromeos/about_os_credits.html --config-dir /mnt/data/b/commit-queue/subversion_config ...
8 years, 8 months ago (2012-04-23 21:57:07 UTC) #5
ferringb
On 2012/04/23 21:56:05, Daniel Erat wrote: > LGTM > > Do you need me to ...
8 years, 8 months ago (2012-04-23 21:57:09 UTC) #6
ferringb
On 2012/04/23 21:57:09, ferringb wrote: > On 2012/04/23 21:56:05, Daniel Erat wrote: > > LGTM ...
8 years, 8 months ago (2012-04-23 22:00:11 UTC) #7
ferringb
Forced line encoding to unix; one minor change in addition, png was swapped back to ...
8 years, 8 months ago (2012-04-24 00:10:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ferringb@google.com/10065004/6002
8 years, 8 months ago (2012-04-24 00:11:03 UTC) #9
commit-bot: I haz the power
Can't apply patch for file chrome/browser/resources/chromeos/about_os_credits.html. While running patch -p0 --forward --force; patching file chrome/browser/resources/chromeos/about_os_credits.html ...
8 years, 8 months ago (2012-04-24 00:11:05 UTC) #10
ferringb
Per instructions, bypassed CQ and fixed the encoding in a separate commit; this should land ...
8 years, 8 months ago (2012-04-24 00:59:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ferringb@google.com/10065004/13001
8 years, 8 months ago (2012-04-24 00:59:36 UTC) #12
commit-bot: I haz the power
Presubmit check for 10065004-13001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-24 01:00:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ferringb@google.com/10065004/13001
8 years, 8 months ago (2012-04-24 01:11:05 UTC) #14
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 02:35:39 UTC) #15
Change committed as 133609

Powered by Google App Engine
This is Rietveld 408576698