Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Side by Side Diff: chrome/browser/prefs/overlay_user_pref_store.h

Issue 10055003: Keep emtpy List/Dictionary pref value with non-empty default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for comments in #1 Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/prefs/overlay_user_pref_store.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_OVERLAY_USER_PREF_STORE_H_ 5 #ifndef CHROME_BROWSER_PREFS_OVERLAY_USER_PREF_STORE_H_
6 #define CHROME_BROWSER_PREFS_OVERLAY_USER_PREF_STORE_H_ 6 #define CHROME_BROWSER_PREFS_OVERLAY_USER_PREF_STORE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 27 matching lines...) Expand all
38 virtual ReadResult GetValue(const std::string& key, 38 virtual ReadResult GetValue(const std::string& key,
39 const base::Value** result) const OVERRIDE; 39 const base::Value** result) const OVERRIDE;
40 40
41 // Methods of PersistentPrefStore. 41 // Methods of PersistentPrefStore.
42 virtual ReadResult GetMutableValue(const std::string& key, 42 virtual ReadResult GetMutableValue(const std::string& key,
43 base::Value** result) OVERRIDE; 43 base::Value** result) OVERRIDE;
44 virtual void SetValue(const std::string& key, base::Value* value) OVERRIDE; 44 virtual void SetValue(const std::string& key, base::Value* value) OVERRIDE;
45 virtual void SetValueSilently(const std::string& key, 45 virtual void SetValueSilently(const std::string& key,
46 base::Value* value) OVERRIDE; 46 base::Value* value) OVERRIDE;
47 virtual void RemoveValue(const std::string& key) OVERRIDE; 47 virtual void RemoveValue(const std::string& key) OVERRIDE;
48 virtual void MarkNeedsEmptyValue(const std::string& key) OVERRIDE;
48 virtual bool ReadOnly() const OVERRIDE; 49 virtual bool ReadOnly() const OVERRIDE;
49 virtual PrefReadError GetReadError() const OVERRIDE; 50 virtual PrefReadError GetReadError() const OVERRIDE;
50 virtual PrefReadError ReadPrefs() OVERRIDE; 51 virtual PrefReadError ReadPrefs() OVERRIDE;
51 virtual void ReadPrefsAsync(ReadErrorDelegate* delegate) OVERRIDE; 52 virtual void ReadPrefsAsync(ReadErrorDelegate* delegate) OVERRIDE;
52 virtual void CommitPendingWrite() OVERRIDE; 53 virtual void CommitPendingWrite() OVERRIDE;
53 virtual void ReportValueChanged(const std::string& key) OVERRIDE; 54 virtual void ReportValueChanged(const std::string& key) OVERRIDE;
54 55
55 void RegisterOverlayPref(const std::string& key); 56 void RegisterOverlayPref(const std::string& key);
56 void RegisterOverlayPref(const std::string& overlay_key, 57 void RegisterOverlayPref(const std::string& overlay_key,
57 const std::string& underlay_key); 58 const std::string& underlay_key);
(...skipping 15 matching lines...) Expand all
73 ObserverList<PrefStore::Observer, true> observers_; 74 ObserverList<PrefStore::Observer, true> observers_;
74 PrefValueMap overlay_; 75 PrefValueMap overlay_;
75 scoped_refptr<PersistentPrefStore> underlay_; 76 scoped_refptr<PersistentPrefStore> underlay_;
76 NamesMap overlay_to_underlay_names_map_; 77 NamesMap overlay_to_underlay_names_map_;
77 NamesMap underlay_to_overlay_names_map_; 78 NamesMap underlay_to_overlay_names_map_;
78 79
79 DISALLOW_COPY_AND_ASSIGN(OverlayUserPrefStore); 80 DISALLOW_COPY_AND_ASSIGN(OverlayUserPrefStore);
80 }; 81 };
81 82
82 #endif // CHROME_BROWSER_PREFS_OVERLAY_USER_PREF_STORE_H_ 83 #endif // CHROME_BROWSER_PREFS_OVERLAY_USER_PREF_STORE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/prefs/overlay_user_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698