Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(53)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/pref_service/read.need_empty_value.json
Issue
10055003
:
Keep emtpy List/Dictionary pref value with non-empty default. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set:
Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/prefs/overlay_user_pref_store.h
chrome/browser/prefs/overlay_user_pref_store.cc
chrome/browser/prefs/pref_service.cc
chrome/browser/prefs/pref_service_mock_builder.h
chrome/browser/prefs/pref_service_mock_builder.cc
chrome/browser/prefs/pref_service_unittest.cc
chrome/browser/prefs/testing_pref_store.h
chrome/browser/prefs/testing_pref_store.cc
chrome/browser/ui/views/ash/launcher/chrome_launcher_delegate.cc
chrome/common/json_pref_store.h
chrome/common/json_pref_store.cc
chrome/common/json_pref_store_unittest.cc
chrome/common/persistent_pref_store.h
chrome/test/data/pref_service/read.need_empty_value.json
chrome/test/data/pref_service/write.golden.need_empty_value.json
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« chrome/common/persistent_pref_store.h
('K') |
« chrome/common/persistent_pref_store.h
('k') |
chrome/test/data/pref_service/write.golden.need_empty_value.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"list": [ 1 ],
3
"list_needs_empty_value": [ 2 ],
4
"dict": {
5
"dummy": true
6
},
7
"dict_needs_empty_value": {
8
"dummy": true
9
}
10
}
OLD
NEW
« chrome/common/persistent_pref_store.h
('K') |
« chrome/common/persistent_pref_store.h
('k') |
chrome/test/data/pref_service/write.golden.need_empty_value.json »
('j') |
no next file with comments »
Issue 10055003: Keep emtpy List/Dictionary pref value with non-empty default. (Closed)
Created 8 years, 8 months ago by xiyuan
Modified 8 years, 8 months ago
Reviewers: battre, sky
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 18
This is Rietveld
408576698
Chromium Code Reviews
Issue 10055003:
Keep emtpy List/Dictionary pref value with non-empty default. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src