Keep emtpy List/Dictionary pref value with non-empty default.

chrome/common/json_pref_store_unittest.cc

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 225 matching lines @@
   pref_store->ReadPrefsAsync(mock_error_delegate);
 
   EXPECT_CALL(mock_observer, OnInitializationCompleted(true)).Times(1);
   EXPECT_CALL(*mock_error_delegate,
               OnError(PersistentPrefStore::PREF_READ_ERROR_NO_FILE)).Times(1);
   message_loop_.RunAllPending();
   pref_store->RemoveObserver(&mock_observer);
 
   EXPECT_FALSE(pref_store->ReadOnly());
 }
+
+TEST_F(JsonPrefStoreTest, NeedsEmptyValue) {
+  FilePath pref_file = temp_dir_.path().AppendASCII("write.json");
+
+  ASSERT_TRUE(file_util::CopyFile(
+          data_dir_.AppendASCII("read.need_empty_value.json"),
+          pref_file));

[battre, 2012/04/11 21:55:51]

nit: indentation

[xiyuan, 2012/04/11 22:36:46]

Done.

+
+  // Test that the persistent value can be loaded.
+  ASSERT_TRUE(file_util::PathExists(pref_file));
+  scoped_refptr<JsonPrefStore> pref_store =
+      new JsonPrefStore(pref_file, message_loop_proxy_.get());
+  ASSERT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, pref_store->ReadPrefs());
+  ASSERT_FALSE(pref_store->ReadOnly());
+
+  // The JSON file looks like this:
+  // {
+  //   "list": [ 1 ],
+  //   "list_needs_empty_value": [ 2 ],
+  //   "dict": {
+  //     "dummy": true,
+  //   },
+  //   "dict_needs_empty_value": {
+  //     "dummy": true,
+  //   },
+  // }
+
+  // Set flag to preserve empty values for the following keys.
+  pref_store->MarkNeedsEmptyValue("list_needs_empty_value");
+  pref_store->MarkNeedsEmptyValue("dict_needs_empty_value");
+
+  // Set all keys to empty values.
+  pref_store->SetValue("list", new base::ListValue);
+  pref_store->SetValue("list_needs_empty_value", new base::ListValue);
+  pref_store->SetValue("dict", new base::DictionaryValue);
+  pref_store->SetValue("dict_needs_empty_value", new base::DictionaryValue);
+
+  // Write to file.
+  pref_store->CommitPendingWrite();
+  MessageLoop::current()->RunAllPending();
+
+  // Compare to expected output.
+  FilePath golden_output_file =
+      data_dir_.AppendASCII("write.golden.need_empty_value.json");
+  ASSERT_TRUE(file_util::PathExists(golden_output_file));
+  EXPECT_TRUE(file_util::TextContentsEqual(golden_output_file, pref_file));
+  ASSERT_TRUE(file_util::Delete(pref_file, false));
+}