Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 10054035: Allow extension APIs to be restricted to a subset of Chrome channels using the (Closed)

Created:
8 years, 8 months ago by not at google - send to devlin
Modified:
8 years, 8 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip+watch_chromium.org, benwells, koz (OOO until 15th September)
Visibility:
Public.

Description

Allow extension APIs to be restricted to a subset of Chrome channels using the Feature system. For example, restricting an API to "dev" means having it available on trunk/canary/dev but not beta/stable. BUG=114231 TEST=unit_tests --gtest_filter=*Feature* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131929

Patch Set 1 #

Total comments: 8

Patch Set 2 : aa #

Patch Set 3 : make default channel "trunk" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -11 lines) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 6 chunks +49 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/bookmarks.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/feature.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M chrome/common/extensions/feature.cc View 1 2 9 chunks +42 lines, -8 lines 0 comments Download
M chrome/common/extensions/feature_unittest.cc View 1 2 3 chunks +97 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
not at google - send to devlin
In the meantime: I'm going to play around with compiling a beta branch or something ...
8 years, 8 months ago (2012-04-11 23:05:54 UTC) #1
Aaron Boodman
https://chromiumcodereview.appspot.com/10054035/diff/1/chrome/common/extensions/feature.cc File chrome/common/extensions/feature.cc (left): https://chromiumcodereview.appspot.com/10054035/diff/1/chrome/common/extensions/feature.cc#oldcode203 chrome/common/extensions/feature.cc:203: return ""; On 2012/04/11 23:05:54, kalman wrote: > Unrelated ...
8 years, 8 months ago (2012-04-11 23:35:52 UTC) #2
not at google - send to devlin
https://chromiumcodereview.appspot.com/10054035/diff/1/chrome/common/extensions/feature.cc File chrome/common/extensions/feature.cc (right): https://chromiumcodereview.appspot.com/10054035/diff/1/chrome/common/extensions/feature.cc#newcode36 chrome/common/extensions/feature.cc:36: channels["trunk"] = VersionInfo::CHANNEL_UNKNOWN; On 2012/04/11 23:35:53, Aaron Boodman wrote: ...
8 years, 8 months ago (2012-04-12 00:05:21 UTC) #3
Aaron Boodman
On Wed, Apr 11, 2012 at 5:05 PM, <kalman@chromium.org> wrote: > > https://chromiumcodereview.appspot.com/10054035/diff/1/chrome/common/extensions/feature.cc > File ...
8 years, 8 months ago (2012-04-12 00:45:48 UTC) #4
not at google - send to devlin
Ok, default supported channel changed to trunk. There weren't any unit tests to update because ...
8 years, 8 months ago (2012-04-12 01:08:42 UTC) #5
Aaron Boodman
tanks! lgtm
8 years, 8 months ago (2012-04-12 02:17:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10054035/3004
8 years, 8 months ago (2012-04-12 02:21:10 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-12 04:45:50 UTC) #8
Change committed as 131929

Powered by Google App Engine
This is Rietveld 408576698