Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: net/spdy/buffered_spdy_framer_spdy2_unittest.cc

Issue 10054034: SPDY - replaced SpdySettings (list) with SettingsMap (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/buffered_spdy_framer_spdy3_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/buffered_spdy_framer_spdy2_unittest.cc
===================================================================
--- net/spdy/buffered_spdy_framer_spdy2_unittest.cc (revision 132592)
+++ net/spdy/buffered_spdy_framer_spdy2_unittest.cc (working copy)
@@ -176,9 +176,11 @@
TEST_F(BufferedSpdyFramerSpdy2Test, OnSetting) {
SpdyFramer framer(2);
- SpdySettings settings;
- settings.push_back(SpdySetting(SettingsFlagsAndId(0, 1), 0x00000002));
- settings.push_back(SpdySetting(SettingsFlagsAndId(0, 1), 0x00000003));
+ SettingsMap settings;
+ settings[SETTINGS_UPLOAD_BANDWIDTH] =
+ SettingsFlagsAndValue(SETTINGS_FLAG_NONE, 0x00000002);
+ settings[SETTINGS_DOWNLOAD_BANDWIDTH] =
+ SettingsFlagsAndValue(SETTINGS_FLAG_NONE, 0x00000003);
scoped_ptr<SpdyFrame> control_frame(framer.CreateSettings(settings));
TestBufferedSpdyVisitor visitor;
@@ -186,8 +188,8 @@
visitor.SimulateInFramer(
reinterpret_cast<unsigned char*>(control_frame->data()),
control_frame->length() + SpdyControlFrame::kHeaderSize);
- EXPECT_EQ(1, visitor.error_count_);
- EXPECT_EQ(1, visitor.setting_count_);
+ EXPECT_EQ(0, visitor.error_count_);
+ EXPECT_EQ(2, visitor.setting_count_);
}
TEST_F(BufferedSpdyFramerSpdy2Test, ReadSynStreamHeaderBlock) {
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/buffered_spdy_framer_spdy3_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698