Issue 10054022: Added a GYP_DEFINE to add libraries to the link line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10054022: Added a GYP_DEFINE to add libraries to the link line. (Closed)

Created:
8 years, 8 months ago by asharif1

Modified:
8 years, 8 months ago

Reviewers:
DaveMoore, sgk

CC:
chromium-reviews, bjanakiraman1

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Added a GYP_DEFINE to add libraries to the link line. When Chrome is built with -fprofile-generate in *_extra_cflags, it needs to link against gcov. Adding -lgcov to the link line doesn't help because it occurs before -Wl,--start-group. This flag correctly adds the required library if used like the test case described below. BUG=102550 TEST=GYP_DEFINES="debug_extra_cflags=-fprofile-generate libraries_for_target=-lgcov" ./build/gyp_chromium make -j5 chrome # passes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132061

Patch Set 1 #

Patch Set 2 : Initialized libraries_for_target. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	build/common.gypi	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asharif@chromium.org/10054022/4001

8 years, 8 months ago (2012-04-12 18:32:24 UTC) #3

Change committed as 132061

Expand Messages | Collapse Messages